Tento compilar commit c7874f805c63c60285f2b190f6589da8ae5e47fa
E falhou com estes erros:
/builddir/build/BUILD/stlink-org-stlink-c7874f8/tests/usb.c: In function 'main':
/builddir/build/BUILD/stlink-org-stlink-c7874f8/tests/usb.c:34:9: error: 'cpuid.revision' may be used uninitialized in this func
tion [-Werror=maybe-uninitialized]
34 | printf("cpuid:part = %#x, rev = %#x\n", cpuid.part, cpuid.revision);
| ^
/builddir/build/BUILD/stlink-org-stlink-c7874f8/tests/usb.c:31:27: note: 'cpuid.revision' was declared here
31 | cortex_m3_cpuid_t cpuid;
| ^
/builddir/build/BUILD/stlink-org-stlink-c7874f8/tests/usb.c:34:9: error: 'cpuid.part' may be used uninitialized in this function [-Werror=maybe-uninitialized]
34 | printf("cpuid:part = %#x, rev = %#x\n", cpuid.part, cpuid.revision);
| ^
/builddir/build/BUILD/stlink-org-stlink-c7874f8/tests/usb.c:31:27: note: 'cpuid.part' was declared here
31 | cortex_m3_cpuid_t cpuid;
| ^
/builddir/build/BUILD/stlink-org-stlink-c7874f8/tests/usb.c:33:9: error: 'cpuid.variant' may be used uninitialized in this function [-Werror=maybe-uninitialized]
33 | printf("cpuid:impl_id = %0#x, variant = %#x\n", cpuid.implementer_id, cpuid.variant);
| ^
/builddir/build/BUILD/stlink-org-stlink-c7874f8/tests/usb.c:31:27: note: 'cpuid.variant' was declared here
31 | cortex_m3_cpuid_t cpuid;
| ^
/builddir/build/BUILD/stlink-org-stlink-c7874f8/tests/usb.c:33:9: error: 'cpuid.implementer_id' may be used uninitialized in this function [-Werror=maybe-uninitialized]
33 | printf("cpuid:impl_id = %0#x, variant = %#x\n", cpuid.implementer_id, cpuid.variant);
| ^
/builddir/build/BUILD/stlink-org-stlink-c7874f8/tests/usb.c:31:27: note: 'cpuid.implementer_id' was declared here
31 | cortex_m3_cpuid_t cpuid;
| ^
lto1: all warnings being treated as errors
Como isso pode ser consertado?
No macOS, o código cria bem.
Em src/common.c
int stlink_cpu_id(stlink_t *sl, cortex_m3_cpuid_t *cpuid) {
uint32_t raw;
if (stlink_read_debug32(sl, STLINK_REG_CM3_CPUID, &raw))
return -1;
cpuid->implementer_id = (raw >> 24) & 0x7f;
cpuid->variant = (raw >> 20) & 0xf;
cpuid->part = (raw >> 4) & 0xfff;
cpuid->revision = raw & 0xf;
return 0;
}
Parece que cpuid.part e cpuid.revision são de fato inicializados aqui. Talvez um compilador se comporte mal?
if (stlink_read_debug32(sl, STLINK_REG_CM3_CPUID, &raw))
return -1;
Nesse caso, cpuid. * Permanece não inicializado.
No Ubuntu também foi compilado com sucesso. A variável cpuid pode usar uninited no caso de erro de registro de leitura.
--- a / tests / usb.c
+++ b / tests / usb.c
@@ -29,7 +29,11 @@ int main (int ac, char ** av) {
printf ("- core_id:% # x \ n", sl-> core_id);cortex_m3_cpuid_t cpuid;
- stlink_cpu_id (sl, & cpuid);
+ if (stlink_cpu_id (sl, & cpuid))
+ {
+ printf ("chip desconhecido \ n");
+ memset (& cpuid, 0, sizeof (cortex_m3_cpuid_t))
+}
printf ("cpuid: impl_id =% 0 # x, variant =% # x \ n", cpuid.implementer_id, cpuid.variant);
printf ("cpuid: part =% # x, rev =% # x \ n", cpuid.part, cpuid.revision);
Acho que pode ser corrigido adicionando uma verificação de valor de retorno em stlink_cpu_id e inicializando esses valores para zero. Vou tentar.
Tenho -Werror=maybe-uninitialized
porque durante a configuração:
-- Performing Test C_SUPPORTS_WMAYBE_UNINITIALIZED
-- Performing Test C_SUPPORTS_WMAYBE_UNINITIALIZED - Success
@Vascom Você pode testar meu branch https://github.com/chenguokai/stlink/tree/issue937 ?
Se funcionar, levantarei um PR.
@Vascom Você pode testar meu branch https://github.com/chenguokai/stlink/tree/issue937 ?
Se funcionar, levantarei um PR.
Sim, funciona.