React-native-onesignal: Seems like you included .git/ folder inside the npm package

Created on 16 May 2019  ·  3Comments  ·  Source: OneSignal/react-native-onesignal

Description:
Seems like you included the .git folder with the package release.
This is problematic because it can throw errors like these when trying to install other packages

npm ERR! path /node_modules/react-native-onesignal
npm ERR! code EISGIT
npm ERR! git /node_modules/react-native-onesignal: Appears to be a git repo or submodule.
npm ERR! git     /react-native-onesignal
npm ERR! git Refusing to remove it. Update manually,
npm ERR! git or move it out of the way first.

Environment
Using "react-native-onesignal": "^3.2.13"

Steps to Reproduce Issue:
Install the package then try to install any other package, i.e.
npm i --save react-native-onesignal
npm i --save react-native-schemes-manager

Anything else:

It can be temporarily fixed by removing /node_modules/react-native-onesignal/.git but the git folder should not be inculded in the npm released package.

Medium Priority Maintenance Issue

Most helpful comment

Hello,
Thanks for bringing this up! We're so sorry and will try to get this fixed asap.

All 3 comments

Yeap and npm install fails every time because of that. It's kind of annoying :)

Hello,
Thanks for bringing this up! We're so sorry and will try to get this fixed asap.

Hello everyone, this has been fixed.

Was this page helpful?
0 / 5 - 0 ratings