React-native-onesignal: InAppMessageClickHandler action inconsistency between iOS and Android

Created on 29 Jun 2020 · 4Comments · Source: OneSignal/react-native-onesignal

Description:

I'm adding support of deeplinking through In-App Messages

As explained in the docs this could be easily done using the InAppMessageClickHandler

Screenshot 2020-06-29 at 17 49 35

I don't know if this has been fixed on newer versions of the Native SDKs (since I'm using the 3.6.4 version of the library)

However I found that the action that comes to the callback of the addEventListener has different naming conventions on iOS and Android, see:

iOS

Screenshot 2020-06-29 at 17 43 56

Android

Screenshot 2020-06-29 at 17 33 51

Environment

react-native-onesignal: 3.6.4

Thanks!

Enhancement / Feature Reproducible

Source

carloscuesta

All 4 comments

Howdy,
Thank you for bringing this up. We will make it consistent across both platforms.

rgomezp on 29 Jun 2020

❤1

Hey @rgomezp I'm a little bit confused I want to upgrade the react-native-onesignal package and the iOS underneath but I don't know if this issue was addressed. I could see on the iOS release notes that this has been fixed but the PR #1013 is still open ?

carloscuesta on 16 Sep 2020

Howdy,
Yeah so we still have to merge the PR in this repository as well. We will get this fix in before the next release.

rgomezp on 17 Sep 2020

❤1

Howdy,
This was merged and released. Thanks for your patience.

Enjoy!

rgomezp on 23 Dec 2020

❤1

Was this page helpful?

0 / 5 - 0 ratings