React-tags: Bugs v.6 Suggestions list

Created on 2 Oct 2019  ·  4Comments  ·  Source: i-like-robots/react-tags

Hi, thanks for a great plugin.

Now we are using version: 6.0.0-beta.1 in production and we found some bugs.

  1. If I set minQueryLength={0} and focus the input for the first time suggestions are not shown.
    But if I write something to input then delete it and unfocus and focus back it works.
    (just trying to accomplish https://github.com/i-like-robots/react-tags/issues/142)

  2. I would like to show only the suggestions which are not selected. For this, my filter function is filtering suggestions prop.
    But when I select a suggestion (suggestions prop is also changed) but your suggestion list still shows old suggestion unless I change something in input.

I think these bugs are maybe related to each other. And it worked in v.5.

I made and a sandbox where you can reproduce bot oh them:
https://codesandbox.io/embed/focused-sunset-r1oox

Thanks for your reply!! :)

bug

All 4 comments

Same issue

Thanks for the report @filippofilip95 and for checking against the previous version. I'll try and recreate this 🤞 for a simple fix.

After a short investigation I believe has been caused by my refactor to move the suggestion list options up into the top-level component to avoid the use of componentWillReceiveProps(). Whether or not it is better to try and revert this change or add extra logic to accommodate it I'm not sure 🤔

These issues have been fixed in #177 and released in v6.0.0-beta.2

Was this page helpful?
0 / 5 - 0 ratings

Related issues

V6
i-like-robots picture i-like-robots  ·  11Comments

williamsidewalk picture williamsidewalk  ·  4Comments

ekinalcar picture ekinalcar  ·  10Comments

yrik picture yrik  ·  10Comments

famouspotatoes picture famouspotatoes  ·  5Comments