React-window: [DynamicSizeList] Rendering items on top of each other if height is the same as estimatedItemSize

Created on 29 Jun 2019  ·  3Comments  ·  Source: bvaughn/react-window

Found a bug on https://github.com/bvaughn/react-window/pull/102, if my items are exactly height 50 (the estimatedItemSize value) they will all render on top of each other:

image

If they have any different height (e.g. 49 or 51) it works:

image

😭 bug
Source
picture brunolemos

Most helpful comment

Fixed in 13d48ad.

picture bvaughn on 1 Jul 2019
👍2

All 3 comments

Ah, interesting edge case. This only holds true if _every_ item is the exact same size as the estimated size. In this case, the list assumes there are no updates to be made. It's not handling the case where content has been rendered for the first time though.

bvaughn picture bvaughn on 1 Jul 2019
👍2

Fixed in 13d48ad.

bvaughn picture bvaughn on 1 Jul 2019
👍2

@bvaughn is this fix part of 1.6.0-alpha.1?

anton6 picture anton6 on 18 Sep 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

maynir picture maynir  ·  4Comments
Kizmar picture Kizmar  ·  3Comments
migueloller picture migueloller  ·  3Comments
carolin913 picture carolin913  ·  3Comments
davalapar picture davalapar  ·  3Comments