React: Use the right document in iframe selection events

Created on 15 Oct 2013  ·  3Comments  ·  Source: facebook/react

We use document directly a bunch where that might not be the right thing if the event is occurring in an iframe. We should do it right. (split from #373)

DOM HTML Bug
Source
picture zpao

Most helpful comment

Woooooo! Cheers to closing a 5 year old issue!!! 🎉🎉🎉🎉

picture nhunzaker on 4 Aug 2018
😄2

All 3 comments

@acusti is it possible that this is is now resolved with the merger of https://github.com/facebook/react/pull/12037?

nhunzaker picture nhunzaker on 4 Aug 2018
👍1

Yes indeed! This issues refers to the previous uses of the global document and window objects in ReactDOMSelection and the SelectEventPlugin.

acusti picture acusti on 4 Aug 2018

Woooooo! Cheers to closing a 5 year old issue!!! 🎉🎉🎉🎉

nhunzaker picture nhunzaker on 4 Aug 2018
😄2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

framerate picture framerate  ·  3Comments
krave1986 picture krave1986  ·  3Comments
jimfb picture jimfb  ·  3Comments
tleunen picture tleunen  ·  3Comments
Prinzhorn picture Prinzhorn  ·  3Comments