Reactstrap: UncontrolledTooltip should not raise an error when the target ID does not exist in the DOM
Issue description
- reactstrap version
^8.0.0 - react version
^16.8.6
What is happening?
UncontrolledTooltip (and maybe other Uncontrolled components?) raise an error in the React application when the target ID does not exist in the DOM.
What should be happening?
Instead of raising an error which can make the whole React application crash (imho this does not seem to be a critical problem, but more of an UX one), maybe it should just warn the developer/user through the console and peacefully not show the tooltip.
Steps to reproduce issue
- Create an UncontrolledTooltip whose target does not exist in the DOM (or can exist or not in the DOM depending to the component state).
Error message in console
No error in console.
Muntaner
👍3
All 3 comments
Having the same issues with Uncontrolled Tooltips and Badges.
rivalver
on 7 Aug 2019
👍1
+1
Also: https://github.com/reactstrap/reactstrap/issues/773, so sometimes it will crash even if the id is spelled correctly.
I think this should be console.error rather than crashing the whole app.
alamothe
on 2 Oct 2019
👍2
Is there any progress on this?
modemmute
on 21 Jun 2020
Was this page helpful?
0 / 5 - 0 ratings
Related issues
vrealjohn
·
3Comments
agos
·
3Comments
clenondavis
·
3Comments
nitingupta910
·
3Comments
sjorsvanheuveln
·
3Comments
Most helpful comment
+1
Also: https://github.com/reactstrap/reactstrap/issues/773, so sometimes it will crash even if the id is spelled correctly.
I think this should be
console.errorrather than crashing the whole app.