Readthedocs.org: Import UI not showing all organizations
I suspect I recently went over 10 organizations in my GitHub account. Now when I see my list of organizations, I'm missing an organization for which I'm an owner (/yougov):
I suspect there's either some pagination going on with the organizations or there's a hard-coded limit of 10. In either case, I seem to be unable to filter by that organization.
jaraco
All 4 comments
This sounds like you might be right, this is likely a bug.
agjohnson
on 13 Nov 2017
This endpoint it's paginated by 25: https://github.com/rtfd/readthedocs.org/blob/6fd828216fede4a64259c5d5f199f8e4fd5163e1/readthedocs/restapi/views/model_views.py#L244
Not sure why you are getting only 10. On the other hand, I didn't find a another possible filter/paginted in the https://github.com/rtfd/readthedocs.org/blob/6fd828216fede4a64259c5d5f199f8e4fd5163e1/readthedocs/projects/static-src/projects/js/import.js code :/
humitos
on 20 Dec 2017
I just found the problem here and it's because we are using a default LimitOffsetPagination as a global setting. Besides, in the involved endpoints we are overriding the paginated_by settings but those are deprecated and since DRF 3.1 it's needed to use a pagination_class.
So, I opened a PR for that at #3559. Please review it and let me know.
humitos
on 27 Jan 2018
@humitos I think there should be a button in the UI for going next
Moroever, if you send page_size parameter while getting the projects, you can control the size from the frontend.
safwanrahman
on 28 Jan 2018
Related issues
boscorelly
·
4Comments
zzzeek
·
4Comments
humitos
·
4Comments
davidfischer
·
4Comments
et304383
·
4Comments
Most helpful comment
I just found the problem here and it's because we are using a default
LimitOffsetPaginationas a global setting. Besides, in the involved endpoints we are overriding thepaginated_bysettings but those are deprecated and since DRF 3.1 it's needed to use apagination_class.So, I opened a PR for that at #3559. Please review it and let me know.