Requests: 418 I'm a Teapot

BTW, I'm aware this is a breaking change; deprecating and delaying to the next major release is fine.

Line of code in question: https://github.com/requests/requests/blob/master/requests/status_codes.py#L55

Please note the alternative versions for 200 OK: https://github.com/requests/requests/blob/master/requests/status_codes.py#L13

Huh. The only thing that causes me concern there is the use of unicode and backslashes; requests doesn't emit those, does it?

Nope, this is for reverse lookup only — same with I'm a teapot.

OK, that's good. The problem is that implementation is being used as evidence to preclude actual use of the status code, which is going to _eventually_ be a problem.

Please see https://github.com/nodejs/node/issues/14644 and https://github.com/golang/go/issues/21326 for discussions regarding similar changes.

I'm okay with removing it, unless we want to add other status codes like 420 and friends.

HTTPbin.org is keeping it though :)

Individual servers, I'm less concerned about :)

Send a PR!

Make it against the 3.0.0 branch though, this will be a breaking change.

Hold on! I'm the guy behind http://save418.com (https://github.com/WhataShane/save418). I, like many others, enjoy stumbling upon (almost entirely) innocuous gags like 418. It's the sort of thing that'll put a smile on your face even when you're pressed to meet a project deadline and your boss is yapping at you one office over. It'd be a real shame to see it go.

To quote @romellem from the Go thread, who quite eloquently sums up the argument for 418:

Just to be clear, is your argument that when/if the 400 block runs out, we'll want that one extra code available to stretch out the usefulness of the 400 block just a bit further?

Unless I'm reading it incorrectly, the 400 block of HTTP status codes has more than 50 codes available. With the available "space" of the 400 block at more than 50%, this might be a pre-mature optimization for a problem that may never occur (400 block running out of available codes, that is).

Not trying to sound harsh, but I for one like fun little easter eggs that you find throughout a programming career. To me, it shows that everything that goes on to make a computer actually do work is still made by humans, and keeping small slices of that human element is nice (in my opinion). Your argument is sound and logical, but this requested change ever so slightly lowers the "fun-ness" of Go (and potentially NodeJS) in the spirit of engineering robustness. At the end of the day, I have to say I don't think that tradeoff is worth it.

(I appreciate the history lesson though! I always thought 418 was a part of the HTTP/1.x spec; didn't know about the "HTCPCP/1.0" spec. 🙂)

I agree that it's a fun easter egg.

Requests takes itself seriously, but not too seriously. :)

This might be the line of "too seriously".

Isn't the obvious answer here to make it part of the spec by starting with a new RFC?

@tSavo Clearly!

While I recognize 418 isn't part of the HTTP status code spec in RFC 7231, it does exist in the wild. Even google has it implemented here. In the unlikely event the IETF decides to implement a real use for 418, we'll have plenty of forewarning to address this. I'm in favor of leaving this as it is unless there's a more compelling reason it needs to be removed.

Give me your keys.

Just to be clear, I agree with the rest of the Requests team: we should keep the 418 mapping here. But the reason I agree is purely pragmatic, not because of the fun Easter egg (though it is fun): codes.py is used to build a mapping from reason phrase to code. For this reason it should include any reason phrase that is somewhat likely to appear for a given code. For the moment that is I'm A Teapot. If this changes, we'll add any other phrase the IANA assigns.

@mnot, feel free to use this response as a commitment that says that the IETF/IANA should feel free to re-use 418, and not to block it on our behalf. 😉 I think reason phrases are stupid anyhow.

A request to register 418 has been submitted to IANA, under number 979050.

Ok; this is not a discussion forum for the merits of 418. @mnot if you want to follow up on this please drop me an email. For everyone else: we appreciate your input, but I feel pretty good about the decision we've made.