Rrule: TZID requires luxon warning, when I have Luxon already

Created on 11 Oct 2020 · 7Comments · Source: jakubroztocil/rrule

[ ] Code sample reproducing the issue. Be sure to include all input values you
See https://stackoverflow.com/questions/64299310/rrule-using-tzid-without-luxon-available-is-unsupported for issue details
[ ] Expected output
No warnings
[ ] Actual output
Using TZID without Luxon available is unsupported. Returned times are in UTC, not the requested time zone
[ ] The version of rrule you are using
Latest
[ ] Your operating system
Ubuntu 18.04
[ ] Your local timezone
Europe/London

Source

mapidemic

👍10

Most helpful comment

I can confirm roll back to 2.6.4 fixes this issue. and I think there are two main issues about this new version update:

as I mentioned in my previous comment, it's quite a big breaking change, it shouldn't just be a minor version increase, I used ^2.6.4 in my package.json, ended up upgrading it to 2.6.6 while I was refreshing the package-lock.json for other reasons.
even with the warning, it's not clear how to "provide luxon", nowhere in this repo mentioned that.

neekey on 18 Oct 2020

👍3

All 7 comments

I think this issue started from 2.6.6? It should not just be a warning, should just throw an error, and in a real application, replace the timezone with UTC will cause serious business issues (in my case I'm writing a medical appointment system, this change caused all the appointments having wrong start time).

neekey on 18 Oct 2020

👍2

I can confirm roll back to 2.6.4 fixes this issue. and I think there are two main issues about this new version update:

as I mentioned in my previous comment, it's quite a big breaking change, it shouldn't just be a minor version increase, I used ^2.6.4 in my package.json, ended up upgrading it to 2.6.6 while I was refreshing the package-lock.json for other reasons.
even with the warning, it's not clear how to "provide luxon", nowhere in this repo mentioned that.

neekey on 18 Oct 2020

👍3

I confirm the issue. Luxon is never found in 2.6.6 and a warning is displayed.

marcoancona on 2 Nov 2020

i am doing a rollup that includes the rrule module and am getting this...

Error: 'DateTime' is not exported by apps/store/code/node_modules/luxon/build/cjs-browser/luxon.js, imported by apps/store/code/node_modules/rrule/dist/esm/src/datewithzone.js
    at error (file:///Users/jkassis/Code/merchie/server/node_modules/rollup/dist/es/shared/rollup.js:5156:30)
    at Module.error (file:///Users/jkassis/Code/merchie/server/node_modules/rollup/dist/es/shared/rollup.js:9659:16)
    at handleMissingExport (file:///Users/jkassis/Code/merchie/server/node_modules/rollup/dist/es/shared/rollup.js:9581:28)
    at Module.traceVariable (file:///Users/jkassis/Code/merchie/server/node_modules/rollup/dist/es/shared/rollup.js:10054:24)
    at ModuleScope.findVariable (file:///Users/jkassis/Code/merchie/server/node_modules/rollup/dist/es/shared/rollup.js:8613:39)
    at FunctionScope.findVariable (file:///Users/jkassis/Code/merchie/server/node_modules/rollup/dist/es/shared/rollup.js:2683:38)
    at ChildScope.findVariable (file:///Users/jkassis/Code/merchie/server/node_modules/rollup/dist/es/shared/rollup.js:2683:38)
    at FunctionScope.findVariable (file:///Users/jkassis/Code/merchie/server/node_modules/rollup/dist/es/shared/rollup.js:2683:38)
    at ChildScope.findVariable (file:///Users/jkassis/Code/merchie/server/node_modules/rollup/dist/es/shared/rollup.js:2683:38)

jkassis on 5 Nov 2020

https://github.com/moment/luxon/issues/252

and

https://github.com/moment/luxon/issues/591

jkassis on 5 Nov 2020

yarn add --ignore-optional rrule does not seem to work. i'll try a custom build without the luxon dependency. sigh.

jkassis on 5 Nov 2020

How do I include Luxon again? I have it on my npm modules but rrule is not working as it was 2.6.4 I get the error Using TZID without Luxon available is unsupported. Returned times are in UTC, not the requested time zone