Rspec-core: undefined method `controller' for RSpec::ExampleGroups

Created on 20 May 2014  ·  3Comments  ·  Source: rspec/rspec-core

Updated from rspec-rails (3.0.0.beta2) to rspec-rails (3.0.0.rc1)

spec

require 'spec_helper'
describe ApplicationController do
  controller do
    def index
      render :text => 'Ok'
    end

    def show
      raise TypeError, 'Any fake value!'
    end
  end

  it "redirects to new_sessions_path" do
    get :index
    expect(response).to redirect_to(new_session_path)
  end
end

Error

spec/controllers/application_controller_spec.rb:5:in `block (2 levels) in <top (required)>': undefined method `controller' for #<Class:0x007fed8fe69180> (NoMethodError)
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/example_group.rb:331:in `module_exec'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/example_group.rb:331:in `subclass'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/example_group.rb:227:in `block in define_example_group_method'
    from /Users/ankitgupta/Documents/projects/work/my-development/spec/controllers/application_controller_spec.rb:4:in `block in <top (required)>'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/example_group.rb:331:in `module_exec'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/example_group.rb:331:in `subclass'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/example_group.rb:227:in `block in define_example_group_method'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/dsl.rb:41:in `block in expose_example_group_alias'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/dsl.rb:79:in `block (2 levels) in expose_example_group_alias_globally'
    from /Users/ankitgupta/Documents/projects/work/my-development/spec/controllers/application_controller_spec.rb:3:in `<top (required)>'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/configuration.rb:1051:in `load'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/configuration.rb:1051:in `block in load_spec_files'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/configuration.rb:1051:in `each'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/configuration.rb:1051:in `load_spec_files'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/runner.rb:97:in `setup'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/runner.rb:85:in `run'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/runner.rb:70:in `run'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/lib/rspec/core/runner.rb:38:in `invoke'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/gems/rspec-core-3.0.0.rc1/exe/rspec:4:in `<top (required)>'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/bin/rspec:23:in `load'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/bin/rspec:23:in `<main>'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/bin/ruby_executable_hooks:15:in `eval'
    from /Users/ankitgupta/.rvm/gems/ruby-2.1.1/bin/ruby_executable_hooks:15:in `<main>'
picture ankit8898

Most helpful comment

rspec-rails 2.x had some very implicit ("magical", to some) behavior where it would infer the spec type based on the file location. In RSpec 3 (starting with RC1) you need to opt-in if you want this, or set the spec type yourself:

describe ApplicationController, :type => :controller do
end

# or

RSpec.configure do |config|
  config.infer_spec_type_from_file_location!
end

See rspec/rspec-rails#970 for more info.

For folks doing the 2.14 -> 2.99 -> 3.0 upgrade path, there are clear deprecation warnings about this, but unfortunately, that's not triggered for 3.0 beta2 -> 3.0 RC1. Sorry about that!

picture myronmarston on 20 May 2014
👍3

All 3 comments

rspec-rails 2.x had some very implicit ("magical", to some) behavior where it would infer the spec type based on the file location. In RSpec 3 (starting with RC1) you need to opt-in if you want this, or set the spec type yourself:

describe ApplicationController, :type => :controller do
end

# or

RSpec.configure do |config|
  config.infer_spec_type_from_file_location!
end

See rspec/rspec-rails#970 for more info.

For folks doing the 2.14 -> 2.99 -> 3.0 upgrade path, there are clear deprecation warnings about this, but unfortunately, that's not triggered for 3.0 beta2 -> 3.0 RC1. Sorry about that!

myronmarston picture myronmarston on 20 May 2014
👍3

@myronmarston Thanks much! :+1:

ankit8898 picture ankit8898 on 21 May 2014

@myronmarston exactly what was wrong. Thank you!

AWaselnuk picture AWaselnuk on 4 Jun 2014
Was this page helpful?
0 / 5 - 0 ratings

Related issues

jfelchner picture jfelchner  ·  3Comments
gaganawhad picture gaganawhad  ·  5Comments
mlapierre picture mlapierre  ·  6Comments
take picture take  ·  5Comments
conradwt picture conradwt  ·  3Comments