Rust: Error code list which need to be updated to new format

I guess I'll go first! I'll take 1, 4, 5, and 9.
Edit: Since there was so much interest, I gave these away. @Roybie has 1, @TheZoq2 has 4, @pythoneer has 5, and @DevShep has 9. Thanks for contributing, folks!

I have no idea what I'm doing. I'll take 10, 17, 23 and 25.

I've also got no idea what I'm doing. I'll take 27, 29, 30, and 34. This should be fun.

For the "I have no idea what I'm doing" crowd - I'm working on a blog post that's going up soon (hopefully tomorrow!) It goes through all the steps of how to update the errors.

Thanks for jumping on them :) Once the blog goes up, I'll reply here with the link.

I've never done this before. I'd like to grab 91, 92, and 93 if that'd be helpful!

I'll take 40 and 46 even though I don't know much about traits.

_Edit: Removing 49 & 50 so that others have chance to contribute as well._

I will take 61, 63 and 69.

Booking 71, 76 and 79. :smiley:

I'll take 81, 87, 88 and 89

I will take 55, 57, and 60

I take 94 and 384 (I think there are no more available)

Might I suggest folks just take on one or two issues, that way others wanting to learn, will have a chance to get involved too.

@lukehinds Yeah, I didn't realize the precedent I was setting, nor how much interest there would be in the issue. If others who haven't contributed before would like to take any of the ones I said I would do (1, 4, 5, 9), they're welcome to it.

I'll gladly take 4 then

I'll wouldn't mind taking number 1 off you then if that's ok?

@lukehinds I'll release 93 then. I can always pick it back up later if no one ends up wanting it.

I would like to try 93 then. Thank you.

@cramertj I'll take 9 of you don't mind.

anything left? i lost count :D

@pythoneer It looks like 5 is still available from the ones @cramertj released

i'll jump on 5 then, thx @TheZoq2

Anything else left?

@pcn @silenuss could you guys free up some of your issues for @yossi-k (and likely some others too!)

Releasing 76 and 79. 😄

Wo. Much more success than expected! I intended to do a big part of it but I guess I'll just review.

@yossi-k: 76 and 79 are free.

I would like to try 76.

I'm on 79 then

@GuillaumeGomez any left?

@GuillaumeGomez any left for me?

I'll take 80

@faebser @nindalf I just removed 49 & 50 from my plate if you're interested on them.

@nindalf: You can take 49 and @faebser will take 50 (thanks @shri3k!).

@shri3k thanks!

Any left to fix? Would love to give this a whirl.

I'm a little late to the party but I was also wondering if there were any left to fix?

@paulfanelli, @birryree: It doesn't seem, no. Sorry. We'll maybe add more in the future but nothing sure.

I'll free up 57 and 60 from the ones I claimed if anyone would like to take one.

@nickmass: Thanks!

@paulfanelli: You take 57 and @birryree you take 60?

Sounds good! I'll take 57. Thx.

I'd like to remind folks to also leave comments on the individual issues themselves, just so that we're totally clear about who's intending to claim what. :)

Blog is posted! You can read how to make the changes here

If you have any questions, feel free to reach out to me or ask on #rust-internals on irc.mozilla.org (I'm jntrnr on there)

Just to second @bstrie's idea, please leave a note on the individual issues if you are taking them.

Also, this is just the first batch! So stay tuned as we fill out additional errors that need to be updated.

Also a huge thanks for everyone jumping in and offering to help!

Also, if you finish an issue, if it has a "Bonus" part and you're not able to complete it...

Once you finish, go ahead and close the issue and open a new issue for just the Bonus part. That way, someone else can jump in and work on the bonus part. You can cc me on the new issue and we can add it to the list above.

For those still looking for error codes to pick up, I just added a new batch to the list on this meta-issue.

I'll take 116!

I take 132.

I'll try to tackle 131.

I can take E0124.

I'd like to try 121

I'll take 106.

@GuillaumeGomez I'll take 60, thanks!

I'll take 109.

@faebser - do you want 50?

Hi! I'd like to take 101 and 102

I'm also up for taking 110 and 119.

If someone wants to take 34, I accidentally took when trying to take 35/36 :D

I'll take 166

I'll grab 117 and 118.

I am taking 164 and 165.

I'll take 101

I'll try 50

I'll take 191.

I can take 162.

I'll take 120

I'll also take E0194.

Forgot to mention this but to use the new error format, you have to run rustc like this:

RUST_NEW_ERROR_FORMAT=1 rustc file.rs

New errors will be added once #35274 is merged.

I'd like to take 184 185 and 186 (not yet listed here) as well

I'll take 178.

taking 172

@franleplant and @dmjb - you both called out 101, but there are others free if one of you wants to take 101 and one take another free one

I'd like to take E0107.

I've updated the list. There are a few free ones. Hoping to add more soon.

I can take E0062 and E0130.

I'll take 137 as well if no one wants it

@keats - go ahead and take it. I'm adding new error codes as we speak

thank you @GuillaumeGomez & @birryree for showing how to get the span labels to show up!

RUST_NEW_ERROR_FORMAT=true ./build/PLATFORM-HERE/stage1/bin/rustc src/test/compile-fail/E0121.rs

For anyone interested in doing one of these, I've put a new batch of error codes into the list.

I've also updated the blog as people had issues here or there, so please check it out.

I'd like to take 322 and 433 as well.

I'll get 206.

Can I take E0379 please

I'll take 201.

I'll take E0404 and E0391 thanks.

I'll take 432.

I'll try 207.

EDIT: My bad didn't notice 206 was taken

I'll take 432 and 425

I'll Take E0277

I'm gonna release E0088 and E0089 if someone else wants them :D

@prabodhtiwari ok then take the 432, I'll will take E0388

@medzin sorry didnt notice you take 432 i will take another one

@prabodhtiwari no problem :)

I'll try E0201.

I'll do E0252 and E0282.

Taking E0326 and E0373.

@mrabault I think @mikhail-m1 took 201 already, but a couple more have been released if you want another one.

I'll take 323, 324 and 325, they seem related

i want to grab 265 as well

Okay so I'll do E0229 instead. I don't understand, E0201 was free when I wrote my message ...

@mrabault - sorry about that. I've been updating the issue by hand when people comment on this thread. It should be up to date now.

No problem !

Taking 306.

i will take 0088 and 0089

Looks like I'm really late, but just putting this here in case someone wants to free something up :)

@likandia: E0204 and E0205 are both available.

@likandia - I added a few more, so there should be more free

I'll take 243 and 244

Helpful tip if you're working on one of these and get a little stuck: look through the PRs for error codes that have been accepted and see how they did the fix. This might give you ideas for yours.

I'll take 204, 205 and 214.

I'll take 220, 221 :+1:

First batch has landed! Great work, everyone.

Taking E0223 as well.

anyway wants E0191? I won't manage to find time for this.

@seblw - I'll free up E0191 so someone else can get it.

I'll take 191 and 225 as well

Alright, batch 2 is in! Another big thanks to everyone who contributed.

I've updated the signups and we're back to no more free ones. But no have no worry, there should be more coming in the next few days.

If you find yourself getting stuck, you can ask for help from some of the other people who have gotten their PRs in. If you don't think you'll have the time to do it, let me know and I'll free it up for someone else to take.

@jonathandturner looks like @munyari already took E0191, but I'll do 225

And @razielgn took 225 right before I was gonna submit :)

Are there any free issues to fix? I'd like to jump in :)

@crypto-universe would you like to take 0221?

@chamoysvoice sure! Thanks! E0221

Batch 3 is in!

Thanks to everyone who has been sharing their tasks. Love seeing that. I should have more tasks on the list starting tomorrow.

Just a heads up - looks like the build servers are having some issues. We're looking into it. I'll post here when they're back up.

Okay if I take E0002?

I'll add you to E0002, @likandia

Can I take E0008?

@srdja - you got it

Grabbing E0026. 😄

33 and 38 please!

@razielgn and @munyari - done!

I'm taking the E0051 bonus (should be E0053 btw).

@KiChjang - good catch :) It's yours

I noticed that some of the pull requests aren't including updated unit tests. I'm wondering if that might count as another bonus part.

@intrepion - we're trying to catch PRs without unit tests so that they always have one. That said, people can always worth together.

I'll take 45

Good news! Looks like the build bots are working again, so we're back in business.

I've celebrated by adding more error codes to the list. If you've been wanting to do a "bonus", there's a lot of new bonuses as well.

I can take 301 and 302.

I did the check_match ones

Hi, I think I will have a go and help my feet get wet, so E0253 & E0254

I will try to do E0263.

@arielb1 - other people have signed up for some of those error codes in that PR, but there are free error codes you can take if you like. You can also collaborate with the people who volunteered for those codes.

I'd like to take 072 and 128

I'd like to claim E0259 and E0260.

I will take E0267 and E0268

I will take E0262, E0261, E0195.

I will take E0133 and E0138.

E0133 and E0138 please :-)

@adrianbrink - sorry, looks like @wdv4758h beat you to it. Maybe you two can split them and do one a piece?

I'll try to add more soon.

Oops ! I didn't notice the message.
I have sent the PRs for both issues, but there is a bonus part in E0138.
Hopefully, I have only implemented half of the bonus part (and thinking how to solve the remaining part).
@adrianbrink I can leave the remaining part for you, if you want.

Are there any free tasks?

@crypto-universe sadly, not yet. I'm hoping to put up more tasks soon.

@jonathandturner If you have any - assign to me, please. Someone commited my task earlier, than me and now I have nothing to do :)

@crypto-universe you can take the other one I was going to work on E0254 https://github.com/rust-lang/rust/issues/35513 (I already have made a PR for E0253)

@lukehinds Thanks a lot! I'll take E0254.

By the way, did you see such problem during check-cfail?

   Compiling compiletest v0.0.0 (file:///home/cryptouniverse/GIT/rust/src/tools/compiletest)
error[E0514]: found crate `log` compiled by an incompatible version of rustc
  --> src/tools/compiletest/src/main.rs:27:1

@crypto-universe - I've seen that sometimes. You'll likely need to run:

python src/bootstrap/bootstrap.py --clean

And try again

@wdv4758h thank you :-)

One more batch just landed. We're one the home stretch now!

@GuillaumeGomez @jonathandturner I'm also interested in picking up some tasks if there's more on the way.

@jonathandturner do you update the task list above? I don't see free tasks.

Are there any left over?

@crypto-universe and @faebser - not yet. Hopefully soon. We're trying to land the next set of unit tests now.

@crypto-universe and @faebser and others looking for more error codes, I just added a couple more.

For those who volunteered earlier but haven't finished your bugs, yet... if you're still working, awesome. If you don't think you're going to be able to get to them, please let someone else work on them.

We're hoping to do more of these in the future, so there should be plenty of things to do :)

I'll take E0375

I can take E0365

I'll take E0370.

I'd like to take E0392

I'll take E0393

I'm going to work E0392

@faebser Sorry but I already claimed and working on it.

Give me 0389, please.

Get them while they're hot! More errors have been added.

And we're _so close_ to having merged 100 error code updates. Great work everyone!

@jonathandturner I'd like to work on E0407.

@crypto-universe and @clementmiao - I've updated the list with the ones you've chosen

I'd like to do 403.

I'll take 409

I take 409

@faebser - @mikhail-m1 already chose 409, but it looks like you meant 408? Signing you up for that one :)

I will take 394 and 422

We have now fixed over 100 unit tests!! 🎉🎉🎉

I'll take a stab at 84

I'll take 232.

I've added a few more, for those interested in grabbing some.

I'm releasing E0432. I don't have a lot of free time recently.

@jonathandturner Give me E0426, please.

I will take 54, 432 and 423

I will take E0435, E0437 and E0438.

I'm snatching up E0424

I'll grab E0428

I've never done this before, would love to jump in and try something new if there are any available error codes that need updating. (Or if someone with multiple is okay giving one up.)

Would anyone with more than one error code be willing to share with @nightlark?

:+1:
bumping to sub myself.

I can pick up some in case someone is willing to release the unfinished ones.

@nightlark & @mkfifo & @0xmohit: I'll certainly add new err code tests today. Once merged, you'll be able to take some if you want.

@mkfifo Use the subscribe button on the right sidebar instead of leaving a no-content comment.

While we wait, would anyone who has volunteered for multiple error codes be willing to share?

@GuillaumeGomez Is there any issues available to work on?

@nightlark & @mkfifo & @0xmohit and @Coder206 - there are new ones posted

I'll take E0450 and E0451

@jonathandturner I'd like to take E0446 as my first contribution to Rust. (#35923)

Also, heads up to people who volunteered but haven't responded after volunteering. I'll going through and opening up some of the previous error codes to make them available for other people to work on. If you have one that you've had for a while and have not gotten to it, you need to respond here to keep it otherwise it will be released.

I'm still working on E0025, it actually seems like it is making me understand the lifetimes/borrow rules.

I'll take E0445, E0454, E0458, E0459.

@0xmohit - can you take 1 or 2 and save some for other people?

@pcn - thanks, I'll keep that one on you

@0xmohit - that is, unless they're all related and easier to do in one shot

@jonathandturner Sure. Striked out a couple. Feel free to mark those to me if there are no takers.

@0xmohit - okay you get E0445 and E0454

Thanks for the new ones @jonathandturner. I'll take E0449.

please. assign E0451 to me

@jonathandturner I'll take E0458 and E0459!

I've released some of the older error codes that weren't being worked on. So there are now more free ones to sign up for.

@jonathandturner I'll take E0260, E0277 and E0453.

I take E0060/E0061 bonuses.

For those looking for bonuses, I've added a few more bonuses at the bottom of the list.

If it's ok, I'll take E0463.

I wanna grab E0088, E0318 and E0221 (with bonuses).
(I will release them asap if I end up not having time for them.)

@yossi-k: Then start with just one or two.

You're right. I'll take up just E0088 and E0221.

@yossi-k E0221 is already fixed, isn't it?
Update: I see, bonus.

@crypto-universe it's in the bonus list below

On Fri, 26 Aug 2016 at 3:43 PM crypto-universe [email protected]
wrote:

@yossi-k https://github.com/yossi-k E0221 is already fixed, isn't it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/rust/issues/35233#issuecomment-242724922,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMZQIVgmVZEkXFap7bH32Q7F6_aXBNFfks5qjt9NgaJpZM4JbLYH
.

I'll take E0049 and E0050 if that's okay

@yati-sagade, @yossi-k, @paulfanelli - I've updated the list with your picks

Can I take E0076 ?

@abhiQmar - yup, E0076 is yours now

I'll take E0265

@mikhail-m1 - done :)

I'll take E0496

@acrrd - done!

Taking E0493.

@jonathandturner I'll take E0164, E0165 and E0184

@razielgn and @gavinb - updated!

@jonathandturner i'll take E0089, E0318 and E0393

I'll take E0318

@zjhmale sorry I posted without refreshing the page, I have almost finish it with only the test to fix; if is ok for you I will send the PR otherwise I move to something else

@acrrd - since there aren't many left, what if you take E0318 and @zjhmale takes E0089 and E0393?

@jonathandturner it's ok for me

@acrrd cool, just go ahead 😄

@jonathandturner ok for me

@jonathandturner I've finished E0164, E0165 and E0184. They're each in their own commit in my fork, but because I messed up resyncing my local and git repos, so I can't make a PR for the newer changes yet. Once my first PR is closed and merged, I'll update my tree to get back in sync with rust-lang and then shoot off a PR for the next 3.

Happy to do some more if any become available. Might take a look at some of the bonus items too.

@gavinb: You can always create a new branch, put your commits in it (or re-doing changes by hand and commit them) and then force push it on your branch.

I just added a few more to the list if people are looking for errors to update.

I'll take on E0512

@mrstork - updated!

Can I take E0527?

@jonathandturner I'll take E0516, E0517, E0518. And I cheekily just put up a PR for these. Hopefully nobody else picked them up in the meantime!

@jonathandturner I'll take E0520.

@jonathandturner

I can take a look at E0516 E0517 E0518 E0520 E0527

All or any

@ashrko619 @gavinb @0xmohit - updated!

@phungleson - looks like those are taken, but hopefully we'll have a few more soon

Just so everyone knows, E0057 and E0072 are still open, and require assistance.

@phungleson: You can look at those proposed by @KiChjang.

@GuillaumeGomez I can look into E0072 first.

@phungleson: Sure.

@GuillaumeGomez @KiChjang @phungleson - isn't E0072 already finished?

Edit: Oooooh, you mean for the bonuses? @phungleson - were you looking for a bonus or a normal fix?

@jonathandturner I haven't worked on it at all, and I don't think anyone else has claimed it, or submitted a PR for it? (I meant the bonus section btw)

@jonathandturner @GuillaumeGomez @KiChjang Yes I meant the bonus for E0072

@jonathandturner Is it okay to take up those ones which are assigned but not got any response for a long time.?

@athulappadan: No. Please wait for @jonathandturner or me say that this is available again.

I'll take E0057

Alright - @phungleson - you've got bonus E0072, and @acrrd - you have bonus E0057

I'd like to take E0559 and E0560 if possible

I will take E0528 and E0259.

@cobrand & @EugeneGonzalez - updated (btw @EugeneGonzalez I'm guessing you meant E0529?)

I'd like to take E0537 bonus

@jonathandturner Yes, sorry about the mix-up.

@EugeneGonzalez - no worries :)

@mikhail-m1 - it's yours!

I'd like to take E0558

@abhi-sm - updated

@abhiQmar - looks like someone beat you to it

@Cobrand, I started working on E0560 (didn't see that you took it), I can continue working on it if you don't mind.

@Cobrand, I started working on E0560 (didn't see that you took it), I can continue working on it if you don't mind.

@aclarry Tbh I had started working on it too, but honestly for the amount of time that I've spent on it, this isn't an issue at all.

@jonathandturner I leave E0560 in @aclarry 's hands

@aclarry Actually, I have to take care of E0559 too, and we'll have to have a look at exactly the same code (src/librustc_typecheck/check/mod.rs lines 3114-3129 ); there is some refactor to do here for both of us. Did you start working on that as well ?

One of us will have to do a merge/rebase at some point if we open our PRs at the same time; I don't mind doing it, but we would probably be better if one did his PR before the other. Since you already started working on it, could you please open your PR quickly so I can adapt to what you've changed ?

Either that, or we can do both of our commits on a common branch (in your fork or mine), and then do a single and grouped PR.

@Cobrand I haven't started working on that section. I'm going to be offline for the next 2 days, so I will put my work on E0560 on pause, and I can merge your changes from E0559.

I'm actually quite new to working on rust, so if you think E0559 and E0560 is a one or two day project for you, I'm also happy to let you go ahead with working on those together, and I can learn from the changes you made for E0560 :) (Take this as leave to take back E0560 if that's easier for you.)

@aclarry I did my PR : https://github.com/rust-lang/rust/pull/36267
I think by the time you get back in 2 days it will be merged ( I hope ), so everything's fine, you can still take E0560.

If it isn't, you can still take a look at what I've changed so it doesn't conflict.
(Btw, please rename E560.rs into E0560.rs in your PR, I almost filed an issue because E0560 wasn't here ...)

Just a heads up that it's probably time to start letting more people work on the errors again. Since we're down to only about 30 left, it may be time to free them up and let other people volunteer.

Also, if you're waiting on a review please either reply here or tag me (or @GuillaumeGomez) in the PR. I've been busy the last few weeks preparing for RustConf but now I'm back.

Paging @arielb1, @pcn, @neilzxu, @GuillaumeGomez, @paulfanelli, @yossi-k, @chamoysvoice, @terrynsun, @faebser, @knight42, @prabodhtiwari, @shyaamsundhar, @Coder206, @nightlark, @mrstork, @aclarry

If I've paged you here, it means that you've claimed one of the still-open bugs above! We understand that life gets busy sometimes, so if you don't have the time to work on those bugs, let us know and we'll free them up for others. :) And if you do want to still work on those bugs but just haven't gotten around to it yet, let us know soon before we start assigning them to new people!

@bstrie I have accomplished my tasks, but it seems that the page didn't get updated.

Ooops, I accidentally closed my PR early for E0370. I can fix it by this weekend.

@knight42, great, I've updated the issues, thanks. :)

@terrynsun, looking forward to it!

Mine has already a PR opened. I wait for @jonathandturner's fix to get merged to update mine.

@bstrie my PR for E0560 is in the process of being merged in, the issue should be closed shortly :)

@bstrie whoops, had my fix, just need to rebase. I'll finish it up by next week.

@bstrie I need to rebase, I'll be up this weekend :zap:

For people needing span merging, my PR landed. You can find merge_spans in CodeMap now.

I didn't see 513 on the list but it needs some help :

error[E0513]: no type for local variable 322
   --> src/gelf.rs:103:41
    |
103 |             mem::transmute_copy::<&[u8; hdr_sz], GelfChunkHeader>(&b[..hdr_sz]);
    |                                         ^^^^^^

hdr_sz in this case was initialized with : std::mem::size_of::()

If someone wants to grab the error @rrichardson points out, make sure to submit a unit test along with it.

I've added an issue for E0513 in the checklist.

@bstrie: Thanks!

I took it.

Greetings all!

Like @bstrie says, it's time for one final push to finish this metabug and call it done.

To get there, we're going to try something a little different. We've opened up the bugs so anyone can send in changes rather than having to sign up. If you create a PR, tag me in it for the review. Let's see how many of these remaining ones we can get done.

Let the last push begin!

@jonathandturner So I can continue E0446?

@Coder206 - yup, anyone can work on E0446. If you're working on it now, you might want to finish it up and send in the PR before someone gets to it first.

Bonuses! There are also new bonuses if you want to work on a bonus

@jonathandturner Any free bonuses? I'd like to take one

Yes! to @mikhail-m1 and anyone interested, there are 5 bonuses on the bonus list that haven't been completed yet. Please feel free to grab one!

@jonathandturner I'll take 'Doesn't live long enough'

@jonathandturner Next time you update the list, I've completed the "EXXXX - Field unknown" bonus with https://github.com/rust-lang/rust/pull/36798. Having a look at the others now.

@gavinb - great! It's updated

Long time no see! I just added a really juicy task with some good bonus material. Niko has gone into great pains to list out the steps that need to go into this, and it's fixing a common pain point: seeing _ instead of the name of the type variable.

You can see the steps here: https://github.com/rust-lang/rust/issues/36554#issuecomment-258427960

I've almost done EXXXX - Fix temporary message and EXXXX - Doesn't live long enough, working on EXXXX - Better mutability

@jonathandturner Looks like all these are done except for the "bonus" bugs. Worth closing this issue?

Make a smaller one would be nice. I'll close once the new smaller one has been created.

@GuillaumeGomez I feel like this ticket can now be closed, as every action item has been taken care of.