Sbt-github-packages: Flag to disable "undefined key" warning
First: Thanks a lot for this plugin @djspiewak!
I do have a very small request: Would it be possible to disable the warning if githubOwner and githubRepository isn't set?
I do get your point why you print this warning, and of course it can stay the default, however if I use the plugin solely to retrieve packages from private repositories (which are libraries for our main project), we do not want to publish to this repositories from within our main project. Setting github-actor and token is enough for such a case. Therefore this warning is very annoying and also can cause problems in CI/CD pipelines.
I am not 100% sure how such a flag should be called. Maybe it should not be about the warning, but more about the purpose how the plugin is used. E.g. notPublishing := true, fetchOnly := true, readOnly := true, publishing := false (which is true by default), repoOnly := true or something like that.
What do you think?
mkurz
All 6 comments
I'm completely okay with suppressing the warning. I'd say something like githubSuppressPublicationWarning := true or something like that. WDYT?
djspiewak
on 14 Feb 2020
Sounds great to me! Thanks!
mkurz
on 14 Feb 2020
Any chance we see this in the next release? Thanks!
mkurz
on 6 Mar 2020
Definitely if I can get to it! Sorry been really swamped. It's not a hard thing to do, just… time. :-( I'll make an 0.4.2 for it though if I can get it done soon.
djspiewak
on 7 Mar 2020
Okay actually this was really easy. Done and released.
djspiewak
on 7 Mar 2020
Nice, thanks a lot!
mkurz
on 7 Mar 2020
Related issues
djspiewak
·
23Comments
dcsobral
·
11Comments
bmjsmith
·
28Comments
hartleys
·
6Comments
tixxit
·
16Comments
Most helpful comment
I'm completely okay with suppressing the warning. I'd say something like
githubSuppressPublicationWarning := trueor something like that. WDYT?