Please see issue https://github.com/sendgrid/nodemailer-sendgrid-transport/pull/28
We want to upgrade that repo and bring it into this monorepo, then deprecate the old package.
Hi @thinkingserious
Can you please shed a little more light on what you hope to achieve? My understanding of this is we need to move the sendgrid-transport module here (/packages). Is it just that?
Thanks!
Hi @iifeoluwa,
We need to do what you describe and update the dependency to match the current version of this SDK.
Thanks!
With Best Regards,
Elmer
Alright, great! @thinkingserious
One more thing though. I was thinking you'd want to merge this PR first before we move the package over.
Moving the package here and recreating the PR might be problematic. What do you think?
Regards.
Hi @iifeoluwa,
That is a great PR, but it's not using the latest version of this SDK.
Alright then, I'll get on with it.
Thanks @thinkingserious
Hello @thinkingserious,
I'm sorry, I won't be able to take this on at the moment. I might get back to it when I have enough time to go through how nodemailer's transport plugin and the mail package API works.
I don't know enough about it right now and wouldn't want to make a mess of things. I apologize for any inconvenience caused.
Regards.
Nodemailer author here. Just FYI I created SendGrid transport module for Nodemailer that is fully compatible (or as much compatible as possible) with Nodemailer API and uses the "@sendgrid/mail" module under the hood to do the actual delivery. You can find the module here: https://github.com/nodemailer/nodemailer-sendgrid
The main reason I created this module was to demonstrate how to use the internal normalize
method available for transports. This method takes nodemailer message structure and converts it to a JSON compatible object that can be used by APIs like SendGrid (all attachments and such are normalized to base64 strings).
update I just realized that the repo was private, so if anyone clicked on the repo link, it probably was 404. Made the repo public.
Is there any update regarding the addition of nodemailer-sendgrid-transport?
Not yet @Berkmann18, this is still working its way up our backlog. Thanks for checking in!
Okay, thanks for letting me know.
Is this issue still relevant? I would give it a go.
@mauricetmeyer Judging by the fact that #707 is still hanging and possibly other PRs then I would guess so.
My apologies for the confusion @mauricetmeyer, I had not updated the labels on this one. I do hope you will consider another issue, there's lots to do :)
Thanks for helping out @Berkmann18!
What is the status of this issue? Anything more needed to be done?
Most helpful comment
Nodemailer author here. Just FYI I created SendGrid transport module for Nodemailer that is fully compatible (or as much compatible as possible) with Nodemailer API and uses the "@sendgrid/mail" module under the hood to do the actual delivery. You can find the module here: https://github.com/nodemailer/nodemailer-sendgrid
The main reason I created this module was to demonstrate how to use the internal
normalize
method available for transports. This method takes nodemailer message structure and converts it to a JSON compatible object that can be used by APIs like SendGrid (all attachments and such are normalized to base64 strings).update I just realized that the repo was private, so if anyone clicked on the repo link, it probably was 404. Made the repo public.