Sentry-javascript: Couldn't removeEventListener on version 5.19.1 in some cases

Created on 9 Jul 2020 · 3Comments · Source: getsentry/sentry-javascript

[x] Review the documentation: https://docs.sentry.io/
[x] Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
[x] Use the latest release: https://github.com/getsentry/sentry-javascript/releases
[ ] Provide a link to the affected event from your Sentry account

Package + Version

[x] @sentry/browser
[x] @sentry/integrations

Version:

5.19.1

Description

Some "removeEventListener methods" didn't work when i upgrade packages to version 5.19.1.

But things work out all right on previous version, such as version 5.15.1.

And i found that this config below will cause "callback.__sentry__" to be "undefined" which committed at https://github.com/getsentry/sentry-javascript/commit/9a68a35836c739757f3d8e9418e21e53e62bd4d2

Sentry.init({
  // ...
  integrations: [new Sentry.Integrations.Breadcrumbs({ dom: false })]
});

Is this the reason that make event listeners which registered after sentry inited couldn't be remove ?

How to fix it ？

Needs Triage

Source

scorpio13love

Most helpful comment

@scorpio13love thanks, I'll look into it. From my first pass, it appears that disabling of dom breadcrumbs is causing it. Very odd though. Will get back to you once I find the issue.

kamilogorek on 9 Jul 2020

👍2 🎉1

All 3 comments

Are you able to provide some sort of repro-case? If there's indeed an issue, I'd like to get it fixed right away.

kamilogorek on 9 Jul 2020

@kamilogorek
I created a repo like this ：https://github.com/scorpio13love/sentry-dom-false.

Input sentry "dsn".
Click button to change router between "page home" and "page detail" several times.
You can count the "page detail click" msg in DevTools Console Or look at the Document's Binding EventListeners.

scorpio13love on 9 Jul 2020

@scorpio13love thanks, I'll look into it. From my first pass, it appears that disabling of dom breadcrumbs is causing it. Very odd though. Will get back to you once I find the issue.

kamilogorek on 9 Jul 2020

👍2 🎉1

Was this page helpful?

0 / 5 - 0 ratings