Setup-miniconda: New repo URL breaks existing workflows

Created on 14 Sep 2020  ·  13Comments  ·  Source: conda-incubator/setup-miniconda

I would have expected runners to follow redirections for actions that have changed location, but they don't...

https://github.com/openforcefield/openforcefield/runs/1114396909?check_suite_focus=true

Thanks to @mattwthompson for the report!

bug

Most helpful comment

I also raised this through their Twitter support and they are looking into it:

https://twitter.com/jaime_rgp/status/1305620040595763204

All 13 comments

Hi @jaimergp, yes I was expecting the redirects to last longer :-|

It does seem to be working as expected after manually updating it: https://github.com/openforcefield/openforcefield/actions/runs/254560374

Thanks for the report @mattwthompson, leaving open as this will probably bite more people :-|

Are all users expected to manually migrate though? Maybe you can post the last version to your goanpeca namespace too, but adding a warning that it's changing locations and that the repo won't receive any more updates?

Are all users expected to manually migrate though? Maybe you can post the last version to your goanpeca namespace too, but adding a warning that it's changing locations and that the repo won't receive any more updates?

Yep that would have been a better path 😆

I do not have time to do this at the moment so I will just create a fork and add a warning later when time clears a bit.

Thanks for the suggestion.

Created this fork, so I guess this should bring it back to life ?

https://github.com/goanpeca/setup-miniconda

Thank you so much for the fast response! That will do in the meantime, yes!

I also raised this through their Twitter support and they are looking into it:

https://twitter.com/jaime_rgp/status/1305620040595763204

Github support has theoretically addressed this: https://twitter.com/mscccc/status/1306002367175823360

I don't know what we should do now, though:

a) Remove the fork and hope the redirection works
b) Keep the fork but add a deprecation warning pointing to the new URL

I would favor b :-)

That would be the nice thing to do.

Thoughts @conda-incubator/setup-miniconda-team ?

Now for how long would redirects work?

I would favor b :-)

Agreed!

Now for how long would redirects work?

As far as I know, they shouldn't expire? source

Let's keep the fork for now while we add the new things.

On account of #84, you'll probably want to upgrade to v2 anyhow...

Was this page helpful?
0 / 5 - 0 ratings