Shinyproxy: Invalid redirection on report error

Created on 20 May 2019  ·  3Comments  ·  Source: openanalytics/shinyproxy

We have the following settings in the config YAML file:

server:
  contextPath: /research-apps
  servlet:
    context-path: /research-apps

Then, when a user reports an issue, the back redirection is invalid. This issue occurs only when running on different context path than /

image

image

image

It seems that the root cause is here: https://github.com/openanalytics/shinyproxy/blob/master/src/main/java/eu/openanalytics/shinyproxy/controllers/IssueController.java#L68

bug

Most helpful comment

Hi, this will be fixed in the next release.
The form is now a client-side only form. So after submitting the form, the modal is closed and the user stays on the same page (without redirect or reload).

All 3 comments

Also, I'm not a big fan of redirecting in case an error occurs (see #63). What I'm thinking about is to add the option redirect-on-error-report (by default TRUE), but when set to FALSE, no redirect would occur.

something like:

proxy:
  support:
    mail-to-address: [email protected]
    mail-from-address: [email protected]
    redirect-on-error-report: <<TRUE/FALSE>> 

What do you think about it? It would be easy to implement and I could prepare the PR if we decide it is worth implementing.

I just noticed we're experiencing this same issue. @donarus did you ever implement this change for your own use?

Hi, this will be fixed in the next release.
The form is now a client-side only form. So after submitting the form, the modal is closed and the user stays on the same page (without redirect or reload).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

erossini picture erossini  ·  3Comments

PauloJhonny picture PauloJhonny  ·  8Comments

lucius-verus-fan picture lucius-verus-fan  ·  8Comments

thomas-chauvet picture thomas-chauvet  ·  5Comments

algo-se picture algo-se  ·  6Comments