Starship: A ` symbol is present before the % symbols on PowerShell

Created on 13 Dec 2019  ·  4Comments  ·  Source: starship/starship

Bug Report

Current Behavior


A ` symbol is present before the % in the battery module in PowerShell:

image

Expected Behavior

The battery module is shown the same way on PowerShell as it is in other shells.

Environment

  • Starship version: starship 0.29.0
  • Shell type: PowerShell
  • Shell version: Powershell 6.2.3
  • Shell plugin manager: N/A
  • Terminal emulator: iTerm2 Build 3.3.7
  • Operating system: macOS 10.15.2

Starship Configuration

[battery]
[[battery.display]]
threshold = 100
style = "bold red"
🐛 bug
Source
picture matchai

All 4 comments

the same code causing this bug is also present in the memory_usage module

qmatias picture qmatias on 13 Dec 2019
👍1

@matchai sorry - I never got around to test that change when I added it. Should I create a PR to remove the special behavior for powershell in these modules or do you already have something for this?

davidkna picture davidkna on 13 Dec 2019

@davidkna We don't yet have end-to-end tests for testing particular shells, but I got a chance to test your changes (#728) locally.

matchai picture matchai on 13 Dec 2019

No this was a change from the initial powershell support pr.

davidkna picture davidkna on 13 Dec 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

teancom picture teancom  ·  4Comments
Adrian-Grimm picture Adrian-Grimm  ·  3Comments
chipbuster picture chipbuster  ·  4Comments
Stupremee picture Stupremee  ·  4Comments
m0nhawk picture m0nhawk  ·  4Comments