Temurin-build: Make it easy to add extra flags at makejdk

Created on 13 Jun 2017 · 6Comments · Source: adoptium/temurin-build

We should be able to pass any extra configure args trivially

See http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2015-June/032392.html which mentions -with-extra-cflags, --with-extra-cxxflags and --with-extra-ldflags

I shouldn't need to modify sbin/build.sh in order to add extra configure args

something like makejdk-any-platform.sh -copts

enhancement

Source

a-roberts

All 6 comments

I think that export CONFIGURE_ARGS_FOR_ANY_PLATFORM="" already does this

gdams on 13 Jun 2017

👍1

added that var to the manpage https://github.com/AdoptOpenJDK/openjdk-build/pull/125

gdams on 13 Jun 2017

@gdams thanks for picking that up - i think documenting this would mean less or no queries in this area. Once the documentation is in place I think we dont need to address this as an issue.

Unless we spot any other flags that might be changing so it can be passed in via CLI.

neomatrix369 on 14 Jun 2017

makejdk-any-platform.sh has hard-coded flags for the various platforms as we (on advise from @tellison) wanted to be able to have one and only one way to build the OpenJDK either local machine or CI system for any specific platform which always worked for everyone - we should continue this. For special cases if users wish to still override those flags, they can now with the help of the documentation very well do that.

neomatrix369 on 14 Jun 2017

👍1

I guess we could make it easier for users to add flags as long as our Jenkins build doesn't change. @tellison thoughts?