Trinitycore: [Trial of Champion] Event bugged. [$50 bounty]

Worse yet. If you go into the instance and mount an Argent Worg and exit the instance mounted it dumps you into the frozen sea in the Borean Tundra with no hope of making it to shore in time (fatigue death). It may do that even if you dismount, not willing to test it any more.

2012-06-14 20:41:28 -0230 (8962b8842584+) (Win64, Release)
8962b8842584610a3597e9e691267b5aaa1c436e
TDB_full_335.11.47_2012_05_19 (+updates)

Random 3 of those 5 mounts are summoned inside the instance and start attacking to players.
The script name on these vehicles are used on only inside the instance, it won't affect outside the instance.

I know, but the mobs of those ids are show on outdoor pics :)

You can apply the patch and test yourself :) I just copied the id's from header file trial_of_the_champion.h.
BTW: I didn't implemented the long introduction.

P.S: Is there any web based IRC? The page irc.rizon.net cannot load.

Yeah, but that don't means it's correct XD

http://www.rizon.net/chat

In #8507, @Pumpush wrote:

hello tc.

the problem is in the first boss(grand champions) i will explain now what happen in the both sides (alliance and horde)

in the alliance: the champions appear without mounts and when you fight them their hp stay on 1 and they dont enter to the next phase

in the horde: the champions of the horde appear like in the alliance and there is a same problem
they appear without mounts and after fighting them they stay on 1 hp and they dont enter to the next phase

how should it work:
for the horde need to appear the alliance faction and after killing them with the mount they need to enter to a new phase and you have to kill them without the mount instead they stay on 1 hp and dont enter to the phase

http://www.wowhead.com/object=195709

hash a7d8a65
TDB: 335.11.47+

From @toxicburnz in #10267:

Trial of the Champion
-This dungeon is completely broken. The first encounter is impossible to complete. You are unable to mount any of the tournament mounts.
-The first encounter is supposed to start with some Role Play where the herald introduces the players and the champions. This doesn't happen.
-[NPC] When the first 3 packs of mobs come out, you are unable to attack any of them.
-[NPC] Most of the enemy mounts are missing an npc and the enemy mounts are friendly when they should be hostile.
-You cannot proceed past this encounter due to being unable to complete it. The entire dungeon needs a new script.

@digz6666

I have been trying to apply your fix but I can't get it to apply. Does this still work ? Should I copy and paste by hand ?

"Trial of the Champion
-This dungeon is completely broken. The first encounter is impossible to complete. You are unable to mount any of the tournament mounts.
-The first encounter is supposed to start with some Role Play where the herald introduces the players and the champions. This doesn't happen.
-[NPC] When the first 3 packs of mobs come out, you are unable to attack any of them.
-[NPC] Most of the enemy mounts are missing an npc and the enemy mounts are friendly when they should be hostile.
-You cannot proceed past this encounter due to being unable to complete it. The entire dungeon needs a new script."

Might it just be in relation with issue #10383 , and that the 3 triplets ads might have no horseman on them because they have been dropped of while getting inside?

In the following act (The Argent Crusade Represenatives) , where you have to fight triplets of ads composed by priests and paladins don´t attack the party, even if you pull one of them.

The path about "the return of the black knight" is working so far.

I also noticed that:

• the grid which will normaly fall down to block the entrance while the encounter stays open;
• the chests have never appeared;
• the alliance mounts are totally useless, because you can´t move them (no interface at all),
• the wolves can be used, they even have the right bar, with the livepool in percentage but the spells are missing (they just appear while dismounting).

Still pretty broken on latest core:
"Once the first encounter is started the three bosses and their nine adds are spawned, however both the bosses and their adds are from the wrong side, they are from the horde side (hence they are friendly), but the mounts of the bosses are from the alliance side.
The adds mounts did not have any riders and it was possible to attempt to mount then, however when attempting to mount you got the message "you can't do that right now", but it was possible to get past this and mount them by runing at them, jumping and trying to mount while being in the air. This would mount you but you would be kicked off after about one second, this would cause the add mount to despawn, so once we had gotten all of them to despawn the bosses engaged.
A few seconds (~10) after the bosses had engaged they jumped off their mounts and simply stood in place, but their mounts continued to attack. The biggest problem with this is that the mounts are unattackable, since you should be damaging the bosses until their hp goes to zero, once that happens they should dismount and get a new full health bar. "

Current core: TrinityCore rev. c0224dd7ca9a 2014-02-01 13:27:16 +0100 (HEAD branch) (Unix, Release)

If anyone wanna fix this instance we can supply sniffs for it, jump into irc.

                    uiVehicle1GUID = pBoss->GetGUID();
                    uint64 uiGrandChampionBoss1 = 0;
                    if (Vehicle* pVehicle = pBoss->GetVehicleKit())
                        if (Unit* unit = pVehicle->GetPassenger(0))
                            uiGrandChampionBoss1 = unit->GetGUID();
                    if (instance)
                    {
                        instance->SetData64(DATA_GRAND_CHAMPION_VEHICLE_1, uiVehicle1GUID);
                        instance->SetData64(DATA_GRAND_CHAMPION_1, uiGrandChampionBoss1);
                    }
                    pBoss->AI()->SetData(1, 0);
                    break;

wrong GUID taken ??

at bool GrandChampionsOutVehicle(Creature* me)....

Creature* pGrandChampion1 = Unit::GetCreature(_me, instance->GetData64(DATA_GRAND_CHAMPION_1));
Creature_ pGrandChampion2 = Unit::GetCreature(_me, instance->GetData64(DATA_GRAND_CHAMPION_2));
Creature_ pGrandChampion3 = Unit::GetCreature(*me, instance->GetData64(DATA_GRAND_CHAMPION_3));

if (pGrandChampion1 && pGrandChampion2 && pGrandChampion3)
....
can't find the creature because GUID is wrong
as result ever returns false

This dungeon is still broken.
The first bosses as said above wont attack and when you eqiup lance and mount you can't use the lance so you can't kill the bosses. If you gm kill the first 3 bosses to get on with the dungeon the lootchest cannot be opened.
When second boss comes the mobs and the boss comes but after clearing the mobs the boss just died by himself and again no chest was lootable.
For the last boss his mount came from above but no boss himself and no loot for killing his mount so unfortunately this dungeon doenst work at all.

https://github.com/TrinityCore/TrinityCore/issues/383#issuecomment-34156567

What is irc and where do I find the fix for this dungeon?

http://collab.kpsn.org/display/tc/IRC

He is looking for the fix, no to help to fix, so pointeless.

@Aokromes I'd like to give it a try. It would be superb, if you could provide me the sniffs.

[Trial of Champion] Event

http://pastebin.com/CfN0Lxni

@bobkhan Specify the source mmm

@bobkhan the file is working properly? Loot, encounter, archiv...

Why remove override?

I have this instance working "properly" on my server, with dialogue and achievements. I could try to merge it.

U can just upload in ZIP somewhere your files. I can too merge it.

https://github.com/xerkoss/TrinityCore/commit/c84fd7be350baec2d86e7ca0a16b55440927088a
code optimization (BossAI, EventMap, magic numbers...) , and sql (spawns, dialogues..) are welcomed.
Take a look, don't be shy.

Open a pull request so we can see the changes more clearly and pick on the stuff that needs to be changed (achievement handling there f.e are total hacks, lfg handling too, spells should deal with both)

No one takes the bounty? :D

You need new glasses https://github.com/TrinityCore/TrinityCore/pull/14478

Rude as always, anyway...cheers.

Sorry, wasn´t following this for a while.

The easiest problem were the mounts (vehicles) in normal instances and in cross faction instances. The spells have to be cleared and it is done.

The less amusing part is the first boss Phase, as the bosses are still spawning wrong, no matter what kind of player group you were inside this dungeon.

The Raid has even more bugs and not working parts, but this belongs to an other posting.

Ps: if I shall try something on my core, please let me know. My spare time is too rare for scripting and my skills are on a "AT+" lvl.

Greetings,

Ben

Added an extra $20 on this in hopes to give someone more incentive to work on it.

https://www.bountysource.com/issues/66373-trial-of-champion-event-bugged [Open] [$50]

probably fixed by this repo https://github.com/TrinityCore/TrinityCore/commits/3.3.5-trial_of_the_champion
anyone can test it

@ceresia & @bumbummen99 : please post some feedback as to which extent this issue is solved.

Sorry for not taking part in conversation that long. Could you please upload some media or a list of issues left to fix? I currently have no time at as i am in the middle of my final exam (software engineering). Otherwise i'd follow @ceresia decision and your view of the state. I have donated to this issue as i wanted it to vanish (it has been around since 2011). I am also satisfied if there is someone actively working on and improving it.

To me it is fixed when it resembels the blizz experience as much as there is information to verify it including infight (spells, movement), phases, emotes/speech and so on. I could offer to take some of my time to create some german translations if there are missing ones.

Very well. This issue will stay open until someone posts a confirmation that the instance works as expected and is more or less stable.

Hey guys - i have took the relevant code from the 3.3.5-trial_of_the_champion branch and adapted it to compile with 3.3.5 revision 826b3cf (from today). I don't know if this is correct to test it this way but at least its compiling and I am testing this ingame at the moment. so far it looks promising.

Update:
I have tested it one time so far 1 time with horde and 1 time with alliance. all looked fine except of a list of in my opinion minor issues. I will make a more detailed list once i do more tests. for now here are some pictures.

https://ibb.co/gQp3J7
https://ibb.co/e3XCBS
https://ibb.co/caherS
https://ibb.co/i1G5WS
https://ibb.co/n9xCBS
https://ibb.co/g8qXBS
https://ibb.co/d3VM5n
https://ibb.co/hhsCBS
https://ibb.co/i0ZQWS
https://ibb.co/eZn15n
https://ibb.co/depsBS
https://ibb.co/exkokn
https://ibb.co/mmYkWS
https://ibb.co/iqruQn
https://ibb.co/bH65WS
https://ibb.co/da215n
https://ibb.co/ijSqy7
https://ibb.co/caruQn
https://ibb.co/gap3J7
https://ibb.co/kM5zrS
https://ibb.co/hPO8kn
https://ibb.co/jUcqy7

i will make a video and detailed explanation for the issues that i may encounter probably later today.
in the meanwhile i would like to know if what i did (taking the code from the old branch and adapting it to work with the updated 3.3.5) is considered acceptable. i just didnt see much point on testing this in an outdated branch.... please correct me if i am wrong.

That ibb.co image server does not seem to be very stable (at least not for me). I saw 1 maybe 2 images, then they turned blank (image disappeared). Most of the other pages timed out as if the server was down. https://imgur.com/ would be a better choice if those images are meant to be useful in any way. Then again, I don't see the point of those images unless there is readable source code along with the images. Maybe you could link your local source branch so we can see what you are talking about.

The main point about TrinityCore is to learn more coding and to follow the existing TC code style standards. I don't see any big problems in implementing a working Trial of the Champions instance, as long as it can be checked by TC members experienced in coding for the TC source to get useful feedback on if the source code changes are acceptable or not.

Hey @tkrokli Thanks for reply. Since on your last message you said that the issue will stay opened until some people post confirmation of this event working and more or less stable, i just wanted to help by testing this out. i actually changed only like 2 or 3 lines to make it compile with one of the latest trinity core rev. I thought that pics (or video) and list of issues (if any) would be a good way to help this. If its not a good way, i will be happy if you can address me to the right place so i can learn how to properly check and/or confirm other people works and not wasting other people time...

Linking a working branch from your own repository would be a good start. I know at least @Jildor and a couple of others would be interested. Maybe even @Keader would like to have a look.

Then again, if the changes you made are so minor that it is mostly the same as the content in https://github.com/TrinityCore/TrinityCore/tree/3.3.5-trial_of_the_champion , I suggest making a PR to the 3.3.5-trial_of_the_champion branch (instead of the regular 3.3.5 branch) to make the 3.3.5-trial_of_the_champion branch more compatible. (I don't know much about your changes yet, so we need to get feedback from other experienced users too.)

@tkrokli Hey thanks again for reply. I tried to merge it with the 3.3.5-trial_of_the_champion but looks like i dont know how to do it properly... its trying to merge all the differences between 3.3.5 and 3.3.5-trial_of_the _champion probably because i used 3.3.5 branch to do this. Maybe i should try a PR to 3.3.5 instead ? there i have no issues...

Looks good so far. Some time in the future, when your PR becomes part of the 3.3.5 branch, we may just delete the 3.3.5-trial_of_the_champion branch from TC, unless one of the TC members finds it is more practical to keep it with the latest changes in a working state before the 3.3.5 branch gets updated again with new changes to the structures.

Can we put a bounty on this issue? Maybe collect 200-300$ bounty funds , and someone will be motivated enough to finalize the scripting of this instance.
I am willing to put 100$

https://github.com/TrinityCore/TrinityCore/pull/21427

@RR2739-VCN : Bountysource page for this issue ticket:
https://www.bountysource.com/issues/66373-trial-of-champion-event-bugged-50-bounty

@illfated Thank you for the link i see the bounty on it.

If anyone have plans to takeover https://github.com/TrinityCore/TrinityCore/pull/21427 plz split it on multiple PRs to make it faster to review and merge.

Hello. does anybody know why the TOC is closed? We are receiving a message "This instance is closed".

@noszone : The simple answer is: Because it does not work well enough to be used (all events must work for the instance to be completable).
If you want more details, ask in IRC : channel #trinity @ irc.rizon.net

@noszone : The simple answer is: Because it does not work well enough to be used (all events must work for the instance to be completable).

it does not work at all.

@ceresia @bumbummen99 make sure to redeploy or withdraw your bounty. New TOS of bountysource will "steal" your money if you dont do so.