Tocropviewcontroller: Swift 5 support?

Created on 2 Apr 2019  ·  8Comments  ·  Source: TimOliver/TOCropViewController

Most helpful comment

I got some time this weekend, so I spent it merging in @OkiRules' Swift 5 PR. It'll be available in CocoaPods the next time I do a release.

For the record, I would like to say I did not appreciate the following things that happened here:

  • Opening an issue with an empty description and a very short title, even though I provide a template on the information I need, forcing me to ask what exactly was the problem here.
  • Pinging me when I didn't reply.

This is the sort of entitled behaviour that makes people not want to contribute to open source. This is a free library I contribute in my free time for no cost. Please remember that.

Thank you.

All 8 comments

Please do not submit an empty issue.

If you're asking about support for a new Swift version, please write here what actually needs changing.

I get a pod conversion to swift 5 needed warning

He means that he would like TOCropViewController to support the latest Swift 5 and Xcode 10.2 and should probably compile with it too.

Any info about release of the new version with swift 5?

@TimOliver

Don't do that.

Guys forking and let's get out of here ...

I got some time this weekend, so I spent it merging in @OkiRules' Swift 5 PR. It'll be available in CocoaPods the next time I do a release.

For the record, I would like to say I did not appreciate the following things that happened here:

  • Opening an issue with an empty description and a very short title, even though I provide a template on the information I need, forcing me to ask what exactly was the problem here.
  • Pinging me when I didn't reply.

This is the sort of entitled behaviour that makes people not want to contribute to open source. This is a free library I contribute in my free time for no cost. Please remember that.

Thank you.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

felipebonezi picture felipebonezi  ·  6Comments

trr-amsiq picture trr-amsiq  ·  10Comments

ntnmrndn picture ntnmrndn  ·  4Comments

dddOO7 picture dddOO7  ·  5Comments

TimOliver picture TimOliver  ·  12Comments