Underscore: Altered export format/API in semver minor breaks community packages

Created on 30 Mar 2020 · 8Comments · Source: jashkenas/underscore

I encountered some very weird bugs today in a third-party package (natural) with errors like TypeError: Cannot read property 'without' of undefined. This turns out to be because it imports underscore like this:

var Tokenizer = require('./tokenizer'),
    util = require("util"),
    _ = require('underscore')._;

It appears that the latest version exports the whole shebang as a default export, not as a named value on the exports. That’s probably fine…except for any packages that do the above.

Perhaps _ should still be exposed as an alias for the default export? Changing something so major as the top-level API seems like a major breaking change (not a _minor_ semver change!), and after all underscore is used as a dependency by a lot of packages out there.

Source

haggholm

👍1

All 8 comments

Same issue here.. seems like _ is being exported as undefined: https://github.com/jashkenas/underscore/issues/2835

lfreneda on 30 Mar 2020

Pinging @jgonggrijp — it looks like we'll need a 1.10.2 patch follow-up.

jashkenas on 30 Mar 2020

❤1

Specifically, I think that it was the removal of the old shim code for the previous Node API that caused the problem, here: https://github.com/jashkenas/underscore/compare/1.9.2...1.10.0#diff-0f36b362a0b81d6f4d4bfd8a7413c75dL45-L60

... @jgonggrijp — do you think there would be a problem with adding something like that back in?

jashkenas on 30 Mar 2020

This is definitely an oversight, sorry about that.

@jashkenas your link doesn't seem to work so I can't see what you mean. Perhaps something like this in the index-default?

var _ = mixin(allExports);
_._ = _;
export default _;

jgonggrijp on 30 Mar 2020

var _ = mixin(allExports);
_._ = _;
export default _;

This is exactly what I was doing! Super.

jashkenas on 30 Mar 2020

This should be fixed now in 1.10.2, which I've pushed up to NPM. Please give that a try, and let me know if everything is back to normal. Apologies for the screwup.

jashkenas on 30 Mar 2020

@jashkenas u r GOD! :angel: Thanks!

lfreneda on 30 Mar 2020

👍1

Great. In that case, fixed in https://github.com/jashkenas/underscore/commit/2a932470303157072015d5ab7f26d40b9deb4634.

jashkenas on 31 Mar 2020

👍1

Was this page helpful?

0 / 5 - 0 ratings