Vaadin-combo-box: Leaking input styles

Created on 20 Dec 2016 · 3Comments · Source: vaadin/vaadin-combo-box

Description

The vaadin-combo-box element styles affect globals scope when using bundling.
All my inputs have padding due to the following lines:

    #input {
      box-sizing: border-box;
      padding-right: 28px;
    }

Source

web-padawan

Most helpful comment

I use polymer-build. AFAIK styles shouldn't live outside of templates, this is the thing which may break globals styles somehow. Will send a PR to fix that.

web-padawan on 20 Dec 2016

👍2 ❤1

All 3 comments

What tools are you using for bundling styles? It’s a local style of <vaadin-combo-box>, I wonder why the tooling does not scope it.

platosha on 20 Dec 2016

It's probably due to <style> being defined outside <template> in https://github.com/vaadin/vaadin-combo-box/blob/master/vaadin-combo-box.html

tomivirkki on 20 Dec 2016

I use polymer-build. AFAIK styles shouldn't live outside of templates, this is the thing which may break globals styles somehow. Will send a PR to fix that.

web-padawan on 20 Dec 2016

👍2 ❤1

Was this page helpful?

0 / 5 - 0 ratings