Vscode: Saving a file no longer keeps it open

Created on 8 Jan 2018 · 3Comments · Source: microsoft/vscode

VSCode Version: 1.20.0-insider (b811600ecc57992a82a1f50ed9bf128065bc8787)
OS Version: macOS High Sierra 10.13.2

Steps to Reproduce:

Open a file (A)
Make no changes
Save file (cmd + s)
Open another file (B)

expected: B opens and A remains open
actual: B opens and A closes
Note: this is a change to previous behavior

Does this issue occur when all extensions are disabled?: Yes/No
Yes, still occurs

bug verified workbench-editors

Source

Brocco

All 3 comments

@isidorn this looks like a regression from your refactoring. in here we pin the editor if no resource is provided but it looks like the resource is an empty object that is passed in. this seems to be originating from this weird rule (that I never understood) in keybindings service.

I fear all the commands you introduced need a check for URI.isURI() to work properly now. I would do this check from the commands though and not from the various helper functions because otherwise it is totally unclear why this check is needed in the first place :-/

bpasero on 9 Jan 2018

👍1

FYI, this seems to have regressed again, should I open a new issue?

Brocco on 19 Jan 2018

@Brocco thanks for letting us know. However this was fixed on friday and should appear in the next insiders release.
Here's that issue https://github.com/Microsoft/vscode/issues/41841