XCODE11
build flag to support parallel development between Xcode 10 & 11 (#12120)textPlaceholder
Muriel color to use tertiaryLabel
on iOS 13.textTertiary
(via textPlaceholder
?) Page icon beside 'new item' should use listIcon
color.tertiarySystemBackground
/ gray80
for the background color. Text should be text
and X icon should be listIcon
.listIcon
. "share this" and "official buttons" should use textSubtle.Switching between dark and light mode #12441
There are no analytics events for this project.
This will finally close #6373 🎉
Let's swap the gray being used for the bottom tab bar to the default system gray color used for tabs. I'm not sure if the color has a name but it's #757575 in dark mode, #999999 in light mode. That will make the tab bar match what's seen in the mockups above.
My Sites subsections outstanding:
Adding this to the pile – the black-on-black text is hard to read
Ghost view in posts / pages has a white background
Ghosts are the loading placeholders? Here's what I'm seeing (expanded and compact mode) and I think it's the ghost item that's already on the checklist:
Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode.
Heading on the New Account screen seen during signup has a white background with very light gray text and the button at the bottom also has a light background:
Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode—seen during Sign In With Apple testing.
Posts cells (expanded view) have white backgrounds for some labels
Spotted a couple examples of this:
Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode.
App logs are displayed with white text on a white background.
Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode.
Plans descriptions are still light colored.
Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode.
Activity screen is still light colored.
Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode.
The countries map in stats is too dark for me to read.
Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode.
Terms of Service link on the "Sign up for WordPress.com" page is too dark to read.
Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode.
Text is black with a black background in Aztec HTML Mode.
Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode.
Adding this here because I haven't seen it in GitHub and want to be sure it's being tracked. Here are the specs for the button changes (in Prologue, Fancy Dialogs) we should make alongside Dark Mode.
Thanks @mattmiklic - button colours should be updated already, it’s just the border style and possibly font choice we need to update now.
Just noticed that the Post Titles on the Site Pages view are dim. I believe they should be white to match the Blog Posts view.
Good catch @iamthomasbishop. The titles should use the text
color and the dates should use textSubtle
.
I just noticed a few wrong background colors in Plugins:
In this one, there's a black backgound behind the text that shouldn't be there. Also, the Version text should use the textSubtle
color, and the body text of the Description should use the text
color.
In the activity log, the text
and textSubtle
colors should be reversed. In this screenshot the "About / Local draft / Draft / Draft page" text should be text
and the "Page draft modified" etc text should be textSubtle
.
There is also a divider below the table footer text which I think should be appearing above it directly adjacent to the table.
On the Plans screen, the "Best for..." text should use the textSubtle
color.
According to the semantic color names spreadsheet, textPlaceholder
uses muriel gray 30 on iOS 13. We should switch that to use the system tertiaryLabel
color for iOS 13 as that's the color Apple says is intended for placeholders.
On the Menus screen:
The chevron-down icon and the icon that's used to drag and reorder items in the menu should both use the textTertiary
color. The Page icon (beside "New item") and the pencil icon (beside "Default Menu") should use the listIcon
color.
Also in Menus, when editing a menu name in dark mode the background color is too light. For iOS 13 we should use tertiarySystemBackground
and for iOS 12 and below we can use muriel Gray 80.
The text should be text
color and the (X) icon should be listIcon
.
Thanks @mattmiklic for these feedback! I already fixed some (even the page in Pages @iamthomasbishop )
Under Sharing > Sharing Buttons / Manage > Edit sharing buttons, the icons in the list should use listIcon
.
Also in Menus, the "Share this" and "Official buttons" text should use whatever we're using elsewhere in this kind of view. I think it's textSubtle
but am not sure.
This is testing 13.2.1.0 from Testflight:
On the New Account created screen, the background color behind the status bar is different from the color behind the rest of the page. The color behind the status bar is the one that's incorrect.
The modal progress indicator that appears after hitting Continue on the New Account screen looks off; this should use a regular material background, a standard spinner, and text
color text; but I'm not sure if that is time consuming. Maybe just using a system gray background in the interim would help so it responds to dark mode.
There's a layout bug on Notifications the first time the screen is loaded. If the user hasn't already allowed notifications it causes the tab bar to be cut off.
If the user has dismissed the push notification prompt, there's just a bunch of extra space above the first notification in the list.
This isn't specific to dark mode but it is new as of 13.2.
I've added all the open reports in here to the task list at the top of this issue.
@frosty I've added the additional issues I saw to the task list (under My Sites, Editor, Reader). If anything is unclear please let me know and I can clarify with screenshots, etc.
Thanks @rachelmcr !
Comment moderation has incorrect background on the comment cell.
Reported: I have a bug in Wordpress iOS night mode. In my iOS 13.1 beta in paragraph and order text is white and background is white to! I hope you will update to fix this.
Pinging @etoledom for that last one.
@melindahelt @elibud that's on Aztec so I think @frosty might also be able to assist with that issue
Profile > Help & Support > My Tickets screen is still light colored:
Tested with WPiOS 13.3.0.0 (TestFlight) on iPhone 6S iOS 13.1 beta 4.
@melindahelt @elibud that's on Aztec so I think @frosty might also be able to assist with that issue
I can take it during the week unless someone is already taking care of it. @frosty, @danielebogo ?
This issue closed because tracking of these issues has now moved over to a Github Project: https://github.com/orgs/wordpress-mobile/projects/45
Most helpful comment
@frosty I've added the additional issues I saw to the task list (under My Sites, Editor, Reader). If anything is unclear please let me know and I can clarify with screenshots, etc.