Yarn: net.minecraft.client.model.Cuboid -> ModelPart

Created on 5 Aug 2019  ·  3Comments  ·  Source: FabricMC/yarn

It's not a cuboid, it can be composed of several boxes and has rotation point information. Then, net.minecraft.client.model.Box (which actually is a cuboid shape) should be renamed to Cuboid to avoid conflicting with net.minecraft.util.math.Box.

picture Runemoro
👍2

All 3 comments

Would even just Part be too generic? Seems a bit strange to have a model prefix when nothing else really does

Prospector picture Prospector on 6 Aug 2019

I wouldn't change Box. Box is the perfect name for it.

ModelPart is okay, though I'd suggest the variationsModelSubPart, SubPart.

Other names like BoxSet, BoxList, RotatedBoxSet and RotatedBoxList all fit as well.

Sollace picture Sollace on 6 Aug 2019
😕2

The model Box name is not great, because it conflicts with the utility box. And it never contains anything, so I think Cuboid is more appropriate.

Pyrofab picture Pyrofab on 6 Aug 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

asiekierka picture asiekierka  ·  4Comments
ChloeDawn picture ChloeDawn  ·  6Comments
Draylar picture Draylar  ·  6Comments
Bixilon picture Bixilon  ·  5Comments
liach picture liach  ·  4Comments