Auto: Hitting GH rate-limit when generating changelog over very large amount of commits

Any chance I could see the repo to play around with?

wow thats a lot of requests

Also if I could get a fuller log that might help

Was actually able to recreate locally. Don't need anything from you other than hope 😉

We do create a lot of similar requests in semantic-release, and we didn't hit the abuse limit, not that I'm aware of. There should be a 3s timeout between requests that create a comment, do you see that happening in your logs?

Just to be sure: do you use a single Octokit instance across all these requests?

Pretty sure we are only creating 1.

That happens here https://github.com/intuit/auto/blob/master/packages/core/src/git.ts#L123

which should only be initialized once at startup https://github.com/intuit/auto/blob/master/packages/core/src/auto.ts#L1643

I can check though

Verfied: only created once

To test this issue on auto:

yarn
yarn build
yarn auto changelog --from v1.0.0 -d

I think this is related to https://github.com/octokit/plugin-throttling.js/issues/108 but we only have 1 instance of octokit running so we shouldn't need to cluster

do you do any GraphQL requests?

Can you confirm that you see the "went over the abuse limits" logs occur at a rate of roughly 1 per 3 seconds?

Ah that might be it. we use @octokit/graphql but I saw today that you can do it straight though octokit. will try that too

we use @octokit/graphql but I saw today that you can do it straight though octokit

Yes, that way it shares the same request settings & request life cycle hooks

🙏

Okay running now. Got an hour on my rate limit wait left though 😢

@hipstersmoothie you can use our github instance if you're hitting this - we are seeing the same thing

Can you link me to the build log?

I have sent you the build log, as this is on a closed repo.

@vincentbriglia I'm pretty sure that i've fixed the problem in your logs in #1424

Could you install the canary version? It's all under a different scope so you'll have to replace all the package names:

yarn add @auto-canary/[email protected]

yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]

@dariye If you could try to test too I would appreciate it!

Tried it out with

"@auto-canary/all-contributors": "9.49.2-canary.1424.17767.0",
"@auto-canary/auto": "9.49.2-canary.1424.17767.0",
"@auto-canary/conventional-commits": "9.49.2-canary.1424.17767.0",
"@auto-canary/first-time-contributor": "9.49.2-canary.1424.17767.0",
"@auto-canary/npm": "9.49.2-canary.1424.17767.0",
"@auto-canary/released": "9.49.2-canary.1424.17767.0",

still an issue with the github runner GITHUB_TOKEN

trying with a personal token now (I have seen some discrepancies before)

didn't work with a personal token either.

I gave you access to the private repo @hipstersmoothie - branch from next branch

Thanks! Was able to solve your issue pretty quick. https://github.com/intuit/auto/pull/1424/commits/d6e7be20f17160d253298146b77648b408377890

I don't think this is the same issue @dariye is having though.

confirmed that that fixed the issue I was having @hipstersmoothie - have a nice weekend !

however @hipstersmoothie this change now stopped publishing and/or correctly calculating semver releases.

I think auto is behaving as expected. I alluded to this here. This is because the conventional commits plugin treat all non-semver commit messages as skip-release (ex: chore, docs, etc).

This is the PR that implemented it https://github.com/intuit/auto/pull/1086

Would you prefer for the conventional commit plugin to not do this? (eg: don't skip for doc/chore/etc)

@vincentbriglia I'm pretty sure that i've fixed the problem in your logs in #1424

Could you install the canary version? It's all under a different scope so you'll have to replace all the package names:

yarn add @auto-canary/[email protected]

yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]
yarn add @auto-canary/[email protected]

@dariye If you could try to test too I would appreciate it!

I'll test it today and get back to you.

@hipstersmoothie this is still an issue when generating a changelog.

So everything seemed to work when I had the --no-changelog flag. However, I took it off and we just try to use auto shipit in the CI and it fails with the same rate limit hit error.

@hipstersmoothie I added a little more context ☝️

@hipstersmoothie thanks a lot for looking into this. I think the recent releases have fixed this. I'll go ahead and close this. auto's working pretty nicely for us now. Thanks again