Distributor: Distributed post attachments localization

Created on 26 Apr 2019  ·  3Comments  ·  Source: 10up/distributor

First of all thank you for the great plug-in!

Currently, attachments in distributed post content are linked back to the hub [from where distributed]. As currently there is a functionality to distribute post attachments as well, I think it would be better to replace the attachments' URL-s in the post content so they reference to current site (use the distributed attachments in post content).

I'll go ahead and send a pull request with that functionality.

enhancement

Most helpful comment

@avag-novembit thanks for the feedback, for the PR, and welcome to Distributor its great to have you here! We'll take a look at the PR and let you know if there are any questions or concerns with the approach... thanks again!

All 3 comments

@avag-novembit thanks for the feedback, for the PR, and welcome to Distributor its great to have you here! We'll take a look at the PR and let you know if there are any questions or concerns with the approach... thanks again!

One reason why this'd be useful is that wp_make_content_images_responsive() can't run on images in distributed content right now – so while on the source, you'd have all the srcset and sizes you'd expect, but on the destination you'd only have a link to a full-size image.

_edit_ Yep, I see the above PR does indeed accommodate this, very cool!

Tagging @arsendovlatyan on this per their request.

Was this page helpful?
0 / 5 - 0 ratings