Django-bootstrap3: Import error for flatatt using upcoming Django 1.11

Created on 6 Feb 2017  ·  6Comments  ·  Source: zostera/django-bootstrap3

In utils.py and components.py there is an import for flatatt as:
from django.forms.widgets import flatatt

but https://docs.djangoproject.com/en/1.10/_modules/django/forms/widgets/ says it should be:
from django.forms.utils import flatatt

I tested and the import error goes away if you change it to that. This is on Django 1.11. Perhaps the import using widgets was a redundancy of utils for backward compatibility? I mean it is in the 1.10 docs using utils.

All 6 comments

The correct import has been from django.forms.utils import flatatt since version 1.8 of Django.

Regardless, this was fixed in 853d499.

Ah indeed, strange that it's been working with up to and including Django 1.10. When will this be available on pypi? 8.1.0 doesn't have this.

It'd be great to see a release of this as Django 1.11b1 has just come out.

When 1.11 is released, we can adjust our testing regime to exclude 1.9 and add 1.11. At that time, the supported versions of Django will be 1.8LTS, 1.10, and 1.11LTS.

https://www.djangoproject.com/download/#supported-versions

1.9 support doesn't need to be removed. but badly need 1.11b1 support

Closed because this was fixed in 853d499. Adding tests for Django 1.11 now. When tests pass, I'll push to PyPI.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jayvdb picture jayvdb  ·  7Comments

kutera picture kutera  ·  8Comments

radzhome picture radzhome  ·  4Comments

gw0 picture gw0  ·  3Comments

gpetukhov picture gpetukhov  ·  3Comments