first of all thanks for the amazing containers, it made my installation a lot easier. I recently created a complete production docker-compose setup. I'ld like to propose/discuss a few changes/additions to this project that I learned doing my Setup.
I'ld be happy to provide PR's for the above points but wanted to get your feedback first, after writing this ticket and finding all the related tickets im pretty sure all the changes are also in your interest, so mainly creating it as todo list for me.
Thanks for your interest in this, I'd love this to happen!
.env
file doesn't really make a whole lot of sense to me, I understand that you probably want to keep your secrets safer, but unless one is using some Linux permissions to deny access to .env
file but not to docker-compose.yaml
, it is kind of useless right? And I am not sure how would one go about doing that.mailman-web
would be best. I am not very interested in #144 at the moment, especially because it doesn't really get us much speed up or anything. Generating static files at startup should usually be fine.Overall, I like most of the ideas. Ideally, we'd want each change to be in their own separate Pull Request and then we can discuss in more details in their respective PRs.
About the .env
file:
.env
I think a PR will make that clearer, its not much work so no hassle if we drop it.
Links are a deprecated feature, by default all containers in a service section are in one network so linked anyway. Hostname and container-name default to the current section in the service definition so the same as currently explicitly defined and i think removing them makes the whole file smaller and therefor easier to understand.
Somewhat related, I integrated these containers into Mailu (https://github.com/Mailu/Mailu) which provides the rest of the stack. Is there interest in such a setup?
@pgeorgi If you already have that integration that you’d like to maintain using these images, I’d be happy to add a link to your repository/post in the documentation.
@pgeorgi definetly
I agree with @morbidick about the .env
file, mainly because it makes updating much easier.
You can simply do a git pull
without polluting your repo.
Also, the .env
file should be in .gitignore
Example: Look at how Sentry does this:
https://github.com/getsentry/onpremise
They also provide an env.example
file which you can copy to your own .env
file.
Most helpful comment
See https://patrick.georgi.family/2019/01/12/combining-mailman-3-with-mailu/