Faraday: change log level in the default log formatter

Created on 15 Nov 2019  ·  4Comments  ·  Source: lostisland/faraday

Hello,

currently, there's no option to specify the log level in the default formatter. I think it would be better if we're able to do that. what do you guys think?

If I implement my own formatter to solve this, will I be able to log the headers/body of the request?

feature help wanted

All 4 comments

Hello @amrrbakry,
you're right, the default formatter uses info and debug log levels and doesn't currently allow you to change that.

We'd be happy to review a PR that adds the possibility to configure that.

You can also implement your own formatter as you said, where you'll have full control of what log level to use. That formatter could inherit from the default one (so you could reuse methods like apply_filters) and you can provide it to the logging middleware as an option.

Hi @iMacTia,

I'd be happy to help with this. I will try to send a PR as soon as possible :+1:

@iMacTia r?

Fixed in #1079 🎉

Was this page helpful?
0 / 5 - 0 ratings

Related issues

aleksb86 picture aleksb86  ·  3Comments

Lewiscowles1986 picture Lewiscowles1986  ·  4Comments

jordansissel picture jordansissel  ·  5Comments

olleolleolle picture olleolleolle  ·  5Comments

QuinnWilton picture QuinnWilton  ·  4Comments