Githawk: Not showing notifications from private repositories

Given that it doesn't request permissions for anything on login, I assume it can only see public information - would be a nice feature though

+1 to both @narup and @Sherlouk -- It will be awesome if we could see notifications from private repositories the user is member of and participating in PRs, issue discussions, etc.

Perhaps a 2.0 feature?

Checking Octobox (http://octobox.io), I found the Github client needs to request permissions to access the repositories of the organization(s) one is member of.

If the permission isn't available, I don't think if a Github client will be able to access notifications from private repositories.

Another thought -- If Freetime requested user's list of repositories with the Github API upon successful authentication and displayed a list of repositories (including private repos), the app could then let the user select which repos they want to authorize thereby allowing notifications to be available.

Ya, I think I need to add the permissions requested via oauth

👍

Adding user to scopes, we'll see if that fixes it. I shouldn't have to request anything since I'm not using the web flow. Simply using the Oauth API to create a new access token on login (stored locally). We'll see if this works...

@narup @burnflare @Malecks @Sherlouk @indyfromoz I added user scope in the last build, but you'll need to re-auth (creates a new token w/ new scope). Mind logging out and back in and checking again?

I need to get a private org setup to test stuff out myself too. Combing the docs and not seeing anything special to do w/ orgs using Oauth. Might ping the octobox folks.

@rnystrom no change for me after signing in / out, killing and restarting app etc. Running build 484.

I didn't get prompted for extra permissions - nothing appears to be diff!

😞

Scopes don't prompt for anything, was just hoping the user would request the backend perms to work. But looks like private org repos need extra privileges. Will dig.

Ok I setup my own private repo to confirm, and reprod the issue. If this is a limitation of the /notifications endpoint, I'll either have to get creative, or (last resort) drop private repo support...

Alright, got it figured out. Will be switching to web oauth flow, that's the only way to request/grant org access.

Solved org access w/ web flow:

https://developer.github.com/apps/building-integrations/setting-up-and-registering-oauth-apps/about-authorization-options-for-oauth-apps/

My new private org notifications show up in my rest client, but not rendering in the app. Figuring that out.

Can we not have multiple accounts now?

@BasThomas nope, not w/ web auth. Sucks, but since GH doesn't really support it, I'm not going to hack around it either.

I am not seeing some notifs from a private repo, and they don't show up in the response either - regression?

[
  {
    "unread" : true,
    "reason" : "subscribed",
    "id" : "270587808",
    "repository" : {
      "private" : false,
      "downloads_url" : "https://api.github.com/repos/rnystrom/GitHawk/downloads",
      "issues_url" : "https://api.github.com/repos/rnystrom/GitHawk/issues{/number}",
      "archive_url" : "https://api.github.com/repos/rnystrom/GitHawk/{archive_format}{/ref}",
      "id" : 89921801,
      "tags_url" : "https://api.github.com/repos/rnystrom/GitHawk/tags",
      "trees_url" : "https://api.github.com/repos/rnystrom/GitHawk/git/trees{/sha}",
      "branches_url" : "https://api.github.com/repos/rnystrom/GitHawk/branches{/branch}",
      "notifications_url" : "https://api.github.com/repos/rnystrom/GitHawk/notifications{?since,all,participating}",
      "pulls_url" : "https://api.github.com/repos/rnystrom/GitHawk/pulls{/number}",
      "releases_url" : "https://api.github.com/repos/rnystrom/GitHawk/releases{/id}",
      "html_url" : "https://github.com/rnystrom/GitHawk",
      "forks_url" : "https://api.github.com/repos/rnystrom/GitHawk/forks",
      "url" : "https://api.github.com/repos/rnystrom/GitHawk",
      "description" : "A GitHub project manager app for iOS.",
      "hooks_url" : "https://api.github.com/repos/rnystrom/GitHawk/hooks",
      "stargazers_url" : "https://api.github.com/repos/rnystrom/GitHawk/stargazers",
      "issue_comment_url" : "https://api.github.com/repos/rnystrom/GitHawk/issues/comments{/number}",
      "assignees_url" : "https://api.github.com/repos/rnystrom/GitHawk/assignees{/user}",
      "languages_url" : "https://api.github.com/repos/rnystrom/GitHawk/languages",
      "full_name" : "rnystrom/GitHawk",
      "subscribers_url" : "https://api.github.com/repos/rnystrom/GitHawk/subscribers",
      "comments_url" : "https://api.github.com/repos/rnystrom/GitHawk/comments{/number}",
      "merges_url" : "https://api.github.com/repos/rnystrom/GitHawk/merges",
      "contributors_url" : "https://api.github.com/repos/rnystrom/GitHawk/contributors",
      "name" : "GitHawk",
      "issue_events_url" : "https://api.github.com/repos/rnystrom/GitHawk/issues/events{/number}",
      "commits_url" : "https://api.github.com/repos/rnystrom/GitHawk/commits{/sha}",
      "git_commits_url" : "https://api.github.com/repos/rnystrom/GitHawk/git/commits{/sha}",
      "keys_url" : "https://api.github.com/repos/rnystrom/GitHawk/keys{/key_id}",
      "labels_url" : "https://api.github.com/repos/rnystrom/GitHawk/labels{/name}",
      "git_refs_url" : "https://api.github.com/repos/rnystrom/GitHawk/git/refs{/sha}",
      "blobs_url" : "https://api.github.com/repos/rnystrom/GitHawk/git/blobs{/sha}",
      "owner" : {
        "id" : 739696,
        "organizations_url" : "https://api.github.com/users/rnystrom/orgs",
        "received_events_url" : "https://api.github.com/users/rnystrom/received_events",
        "following_url" : "https://api.github.com/users/rnystrom/following{/other_user}",
        "login" : "rnystrom",
        "avatar_url" : "https://avatars2.githubusercontent.com/u/739696?v=4",
        "url" : "https://api.github.com/users/rnystrom",
        "subscriptions_url" : "https://api.github.com/users/rnystrom/subscriptions",
        "type" : "User",
        "repos_url" : "https://api.github.com/users/rnystrom/repos",
        "html_url" : "https://github.com/rnystrom",
        "events_url" : "https://api.github.com/users/rnystrom/events{/privacy}",
        "site_admin" : false,
        "starred_url" : "https://api.github.com/users/rnystrom/starred{/owner}{/repo}",
        "gists_url" : "https://api.github.com/users/rnystrom/gists{/gist_id}",
        "gravatar_id" : "",
        "followers_url" : "https://api.github.com/users/rnystrom/followers"
      },
      "subscription_url" : "https://api.github.com/repos/rnystrom/GitHawk/subscription",
      "deployments_url" : "https://api.github.com/repos/rnystrom/GitHawk/deployments",
      "milestones_url" : "https://api.github.com/repos/rnystrom/GitHawk/milestones{/number}",
      "contents_url" : "https://api.github.com/repos/rnystrom/GitHawk/contents/{+path}",
      "events_url" : "https://api.github.com/repos/rnystrom/GitHawk/events",
      "teams_url" : "https://api.github.com/repos/rnystrom/GitHawk/teams",
      "collaborators_url" : "https://api.github.com/repos/rnystrom/GitHawk/collaborators{/collaborator}",
      "git_tags_url" : "https://api.github.com/repos/rnystrom/GitHawk/git/tags{/sha}",
      "statuses_url" : "https://api.github.com/repos/rnystrom/GitHawk/statuses/{sha}",
      "fork" : false,
      "compare_url" : "https://api.github.com/repos/rnystrom/GitHawk/compare/{base}...{head}"
    },
    "subscription_url" : "https://api.github.com/notifications/threads/270587808/subscription",
    "subject" : {
      "latest_comment_url" : "https://api.github.com/repos/rnystrom/GitHawk/issues/comments/339895997",
      "title" : "Report bug from screenshot",
      "url" : "https://api.github.com/repos/rnystrom/GitHawk/issues/755",
      "type" : "Issue"
    },
    "last_read_at" : "2017-10-27T04:53:55Z",
    "updated_at" : "2017-10-27T07:32:55Z",
    "url" : "https://api.github.com/notifications/threads/270587808"
  }
]

(after marking above notification as read)

Has the repo granted access to GitHawk?

Ah, that could be it 👍

_{Sent with GitHawk}

Sorry for the false alarm 😬

_{Sent with GitHawk}

I wonder if we can make it more clear somehow... probably some scanning on “new issue” before submitting would help.

_{Sent with GitHawk}

Maybe a simple FAQ? Could also mention this from the issue template

_{Sent with GitHawk}