would be nice to be able to also approve or disapprove prs. I can do everything except for that.
Bug Report Dump (Auto-generated)
Version 1.22.0 (1534395229) Device: iPhone X (iOS 11.4.1) TestFlight: false
moimikey
All 12 comments
Aaaaaaabsolutely. The next update I want to get these local pushes working, then focus on a PR-rich update.
Sent with GitHawk
rnystrom
on 13 Sep 2018
@rnystrom I will have some time to jump on that. I recenlty changed my github workflow to 100no emails :)
flovilmart
on 30 Jan 2019
yey
moimikey
on 31 Jan 2019
@rnystrom did you have anything in mind for the positioning of such actions?
I am futzing with multiple options:
- From the menu (with labels and milestones) add Approve / Reject
- From the menu add 'Add Review' which pushes a new controller with a textView + MergeButton (customized)
- From the files list
etc...
flovilmart
on 31 Jan 2019
What is the status of this feature? If I can weight in on the location, it would be really cool to be able to see the “Add review” button in place of the “Not authorized to merge” when there is a missing but required review. Additionally I think it would be natural to add this to the files view to keep it consistent with github’s process.
peterdemartini
on 1 Jul 2019
I barely I started with playing with the code. The task is quite daunting when you consider all the cases. I’ll hopefully have time to look at it soon
Sent with GitHawk
flovilmart
on 1 Jul 2019
Woah! This would be awesome 👏
Sent with GitHawk
Huddie
on 11 Jul 2019
is this feature request still planned?
jonsch
on 27 Oct 2019
Approving a PR was the first task I needed to do when downloading and opening githawk a few minutes ago. Looks like a great app, but the lack of the ability to do PR review has me downloading another app.
leecalcote
on 9 Jan 2020
@leecalcote also given I requested it in 2018 and we're in 2020 now. :(
moimikey
on 13 Jan 2020
Bump, as a open source project maintainer this feature is greatly needed
sfdye
on 6 Mar 2020
I won’t have time to work on this, unassigning myself
flovilmart
on 17 Mar 2020
Related issues
rnystrom
·
3Comments
BasThomas
·
3Comments
BasThomas
·
3Comments
rnystrom
·
3Comments
rnystrom
·
3Comments
Most helpful comment
I barely I started with playing with the code. The task is quite daunting when you consider all the cases. I’ll hopefully have time to look at it soon
Sent with GitHawk