Laravel-log-viewer: Upgrade to bootstrap 4
Bootstrap 3 is a bit obsolete now. We should upgrade it to Bootstrap 4 (warning: datatables is configured for bootstrap 3 I think, we have to check that before)
_Side note: I can help/mentor/validate if someone want to tackle this issue._
rap2hpoutre
All 7 comments
After one month of Bootstrap 4 stable, the 3ird is yet obsolete?
Guys how many sites you develop?
withArtur
on 23 Feb 2018
😄 "Obsolete" is barbaric, you are right! Sorry about that.
Still, Laravel 5.6 is now shipped with bootstrap 4. So it's the new "standard" I guess.
rap2hpoutre
on 23 Feb 2018
i am actually working through this right now within a project of mine, and if i can abstract it back out to your package i'll be happy to share.
one thing we lose with bs4 is glyphicons - docs recommend using a 3rd party font library instead. do you have a preferred font library? i personally use fontawesome but that's just out of habit at this point. 😃
mattlibera
on 27 Feb 2018
Fontawesome is great, It's my default choice too. Maybe there are some better/lighter alternatives (but I don't know which one is good)...
i am actually working through this right now within a project of mine, and if i can abstract it back out to your package i'll be happy to share.
👍
rap2hpoutre
on 28 Feb 2018
sounds good to me! i'll dig in and see if i can get you an ETA. there are already libraries for datatables that support bs4 so that part is easy to drop in.
mattlibera
on 28 Feb 2018
PR is in! happy to discuss anything / everything. #122
mattlibera
on 28 Feb 2018
Thanks!
rap2hpoutre
on 1 Mar 2018
Related issues
mstaack
·
6Comments
watermelonjuice
·
8Comments
avesgit
·
7Comments
raksa
·
3Comments
serdarsaygili
·
11Comments
Most helpful comment
Fontawesome is great, It's my default choice too. Maybe there are some better/lighter alternatives (but I don't know which one is good)...
👍