Laravel-log-viewer: Log content nearly uncopyable

Created on 24 Jun 2020  ·  2Comments  ·  Source: rap2hpoutre/laravel-log-viewer

Firstly thank you for the great package.

Secondly I think it would be a huge improvement to make a specific log row NOT close when clicked upon.

To close the row, the user should be forced to click the icon button that looks like a magnifying glass.

The reason being is that a lot of times it is convenient to copy some of the content from the row. To do so, you obviously need to click on your text to highlight it, but that just closes the row inconveniently.

Only with great effort can you make a text selection by: highlighting it initially, wait for the row to close, and then reopening it with the magnifying glass.

I haven't look at the code for the front-end yet as I am experienced in react but not jquery.

Most helpful comment

Turns out it wasn't that hard to change the toggle to use the button instead of the row itself.

ORIGINAL

$('.table-container tr').on('click', function () {
      $('#' + $(this).data('display')).toggle();
    });

NEW

$('.table-container tr button').on('click', function () {
      $('#' + $(this).data('display')).toggle();
    });

I can make a PR if others think this is worthy of being a package default behavior.

All 2 comments

Turns out it wasn't that hard to change the toggle to use the button instead of the row itself.

ORIGINAL

$('.table-container tr').on('click', function () {
      $('#' + $(this).data('display')).toggle();
    });

NEW

$('.table-container tr button').on('click', function () {
      $('#' + $(this).data('display')).toggle();
    });

I can make a PR if others think this is worthy of being a package default behavior.

Oh, can't even tell you how I suffer from this "perfectly designed" UX.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

DevynCJohnson picture DevynCJohnson  ·  5Comments

serdarsaygili picture serdarsaygili  ·  11Comments

rap2hpoutre picture rap2hpoutre  ·  7Comments

avesgit picture avesgit  ·  7Comments

raksa picture raksa  ·  3Comments