Libelektra: crypto_botan: botan 2.13 header deprecation warnings

Created on 9 Apr 2020  ·  3Comments  ·  Source: ElektraInitiative/libelektra

As of botan 2.13.x (maybe earlier?) we started getting the following header deprecation warnings:

In file included from ../src/plugins/crypto/botan_operations.cpp:12:
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/hmac.h:14:1: warning: this header will be made internal in the future [-W#pragma-messages]
BOTAN_FUTURE_INTERNAL_HEADER(hmac.h)
^
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/compiler.h:107:49: note: expanded from macro 'BOTAN_FUTURE_INTERNAL_HEADER'
      #define BOTAN_FUTURE_INTERNAL_HEADER(hdr) _Pragma("message \"this header will be made internal in the future\"")
                                                ^
<scratch space>:100:2: note: expanded from here
 message "this header will be made internal in the future"
 ^
In file included from ../src/plugins/crypto/botan_operations.cpp:13:
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/init.h:16:1: warning: this header is deprecated [-W#pragma-messages]
BOTAN_DEPRECATED_HEADER(init.h)
^
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/compiler.h:104:42: note: expanded from macro 'BOTAN_DEPRECATED_HEADER'
    #define BOTAN_DEPRECATED_HEADER(hdr) _Pragma("message \"this header is deprecated\"")
                                         ^
<scratch space>:102:2: note: expanded from here
 message "this header is deprecated"
 ^
In file included from ../src/plugins/crypto/botan_operations.cpp:14:
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/lookup.h:35:1: warning: this header is deprecated [-W#pragma-messages]
BOTAN_DEPRECATED_HEADER(lookup.h)
^
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/compiler.h:104:42: note: expanded from macro 'BOTAN_DEPRECATED_HEADER'
    #define BOTAN_DEPRECATED_HEADER(hdr) _Pragma("message \"this header is deprecated\"")
                                         ^
<scratch space>:104:2: note: expanded from here
 message "this header is deprecated"
 ^
In file included from ../src/plugins/crypto/botan_operations.cpp:15:
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/pbkdf2.h:16:1: warning: this header will be made internal in the future [-W#pragma-messages]
BOTAN_FUTURE_INTERNAL_HEADER(pbkdf2.h)
^
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/compiler.h:107:49: note: expanded from macro 'BOTAN_FUTURE_INTERNAL_HEADER'
      #define BOTAN_FUTURE_INTERNAL_HEADER(hdr) _Pragma("message \"this header will be made internal in the future\"")
                                                ^
<scratch space>:106:2: note: expanded from here
 message "this header will be made internal in the future"
 ^
In file included from ../src/plugins/crypto/botan_operations.cpp:17:
In file included from /usr/local/Cellar/botan/2.13.0/include/botan-2/botan/sha2_32.h:12:
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/mdx_hash.h:13:1: warning: this header will be made internal in the future [-W#pragma-messages]
BOTAN_FUTURE_INTERNAL_HEADER(mdx_hash.h)
^
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/compiler.h:107:49: note: expanded from macro 'BOTAN_FUTURE_INTERNAL_HEADER'
      #define BOTAN_FUTURE_INTERNAL_HEADER(hdr) _Pragma("message \"this header will be made internal in the future\"")
                                                ^
<scratch space>:108:2: note: expanded from here
 message "this header will be made internal in the future"
 ^
In file included from ../src/plugins/crypto/botan_operations.cpp:17:
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/sha2_32.h:14:1: warning: this header will be made internal in the future [-W#pragma-messages]
BOTAN_FUTURE_INTERNAL_HEADER(sha2_32.h)
^
/usr/local/Cellar/botan/2.13.0/include/botan-2/botan/compiler.h:107:49: note: expanded from macro 'BOTAN_FUTURE_INTERNAL_HEADER'
      #define BOTAN_FUTURE_INTERNAL_HEADER(hdr) _Pragma("message \"this header will be made internal in the future\"")
                                                ^
<scratch space>:110:2: note: expanded from here
 message "this header will be made internal in the future"
 ^
6 warnings generated.

Botan maintains a docu of deprecated headers.

build dependencies
Source
picture mpranj

Most helpful comment

what is the best way forward? Maybe we should remove some of the crypto plugins (with duplicated functionality) to keep maintenance effort reasonable?

Since the variations of the crypto plugin have been introduced for academic research (whis has been finished two years ago) I think the best way to go on is to keep the libgcrypt version and drop the rest (botan, OpenSSL). I will open another ticket.

picture petermax2 on 10 Apr 2020
👍3

All 3 comments

Thank you for reporting this problem!

@petermax2: what is the best way forward? Maybe we should remove some of the crypto plugins (with duplicated functionality) to keep maintenance effort reasonable?

markus2330 picture markus2330 on 9 Apr 2020

what is the best way forward? Maybe we should remove some of the crypto plugins (with duplicated functionality) to keep maintenance effort reasonable?

Since the variations of the crypto plugin have been introduced for academic research (whis has been finished two years ago) I think the best way to go on is to keep the libgcrypt version and drop the rest (botan, OpenSSL). I will open another ticket.

petermax2 picture petermax2 on 10 Apr 2020
👍3

Botan support was removed.

petermax2 picture petermax2 on 13 Apr 2020
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

mpranj picture mpranj  ·  3Comments
sanssecours picture sanssecours  ·  3Comments
darddan picture darddan  ·  4Comments
dmoisej picture dmoisej  ·  3Comments
mpranj picture mpranj  ·  3Comments