Meilisearch-laravel-scout: Linter

Created on 18 Apr 2020  ·  2Comments  ·  Source: meilisearch/meilisearch-laravel-scout

We should have a linter so that everyone can easily contribute without messing the code 🙂

Steps:

  • [ ] Add and configure the linter
  • [ ] Add the command in README in the Development Workflow part
  • [ ] Add it in GitHub Action to be triggered on each PR
Laravel integration

Most helpful comment

Thanks for the suggestion @pet1330! 😊

After discussing with the team, we would rather not to use styleCI since it needs to access to our organization content:
Capture d’écran 2020-05-04 à 17 11 01

We are going to install a basic linter like php-cs-sniffer (already used in the PHP SDK).

All 2 comments

You can quickly automate this step by using styleci, it is free for opensource

Thanks for the suggestion @pet1330! 😊

After discussing with the team, we would rather not to use styleCI since it needs to access to our organization content:
Capture d’écran 2020-05-04 à 17 11 01

We are going to install a basic linter like php-cs-sniffer (already used in the PHP SDK).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

curquiza picture curquiza  ·  4Comments

marky291 picture marky291  ·  6Comments

JexPY picture JexPY  ·  8Comments

curquiza picture curquiza  ·  17Comments

Kladislav picture Kladislav  ·  8Comments