Milligram: Normalize.css v.6.0.0 breaks input font-size styling

Created on 29 Mar 2017  ·  7Comments  ·  Source: milligram/milligram

It seems like some input element styles have been removed in version 6.0.0. Therefore, input font-size property is now inherited from user-agent styles.

Normalize v.5.0.0.
screen shot 2017-03-29 at 15 47 58

Normalize v.6.0.0.
screen shot 2017-03-29 at 15 47 42

Hacktoberfest

Most helpful comment

I agree with you in that using normalize.css is overkill.

Yah that was just an aside.

I guess I agree with this issue. Maybe Milligram could incorporate a mini-reset, similar to the one I posted.

All 7 comments

Therefore, input font-size property is now inherited from user-agent styles.

Isn't that a problem with Normalize.css then?

It is possible that it might be a problem with Normalize.css. I will open a ticket and report back.

It seems like they removed all opinionated css rules from Normalize.css. See the commit #649. Removed form element styles include the ones -such as font-size- that can be inherited from body. Some of these rules can be included in milligram to make form styles consistent with the rest of the framework.

Huh, that's...intense. Your screenshot is still weird though, because the forms on https://milligram.github.io/forms.html look totally normal and I'm pretty sure they don't use normalize. So I still think this is not an issue with Milligram.

FWIW I use a far smaller CSS reset with Milligram: https://github.com/nateberkopec/speedshop/blob/master/_sass/mini-reset.sass

Milligram is ~9kb uncompressed/unminified, and Normalize is ~7.5kb. Using a CSS reset that's the same size as your framework is excessive in my view.

Forms look normal because it uses normalize.css 5.0.0. Check out the source. And since your reset has styles in common with normalize.csss 5.0.0, it is possible that you are unaffected.

I agree with you in that using normalize.css is overkill. But the size is not the issue here. The issue is regardless of the reset I am using, whether I will be able to get the appearance advertised on milligram's site. I guess that is what is related to milligram.

I agree with you in that using normalize.css is overkill.

Yah that was just an aside.

I guess I agree with this issue. Maybe Milligram could incorporate a mini-reset, similar to the one I posted.

@negativefix congrats to the huge job!
Thank you so much.

@nateberkopec you're right. It's time for a change normalize.css. I had worked on a new one, but I spent a lot of time away from Milligram. So I need to redo the necessary studies/tests to ensure that everything is okay.

btw, I bring news: Milligram v1.4.0 https://github.com/milligram/milligram/pull/244

Please, tell me if I can help you with something.
For now, I will close this issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

equinusocio picture equinusocio  ·  14Comments

roryprimrose picture roryprimrose  ·  7Comments

garretwilson picture garretwilson  ·  18Comments

luisaceituno picture luisaceituno  ·  6Comments

swalberg picture swalberg  ·  6Comments