Plots2: Showing contributors on /contributors/____ pages
https://publiclab.org/contributors/microplastics says 8 contributors, but below on that page nobody is listed.
The code is here: https://github.com/publiclab/plots2/blob/master/app/views/tag/contributors.html.erb
But it's driven by this controller code:
Any help fixing this would be appreciated!!!
We should also work to add a test to ensure this page gets properly populated. We could do a functional test in this file:
There, we don't really count contributors. We should!
Using assert_equal assigns(:users), 99 (where 99 is the expected number of users)
jywarren
All 3 comments
I think there may have been a reversion in #2180 which affected @Gauravano's code in #2062:
It looks like @noteCount was changed to @note_count and I've reverted that in #2479. I want to add a functional test to ensure these are shown.
jywarren
on 12 Mar 2018
Attempting fix in #2479
jywarren
on 12 Mar 2018
jywarren
on 12 Mar 2018
Related issues
RuthNjeri
·
3Comments
ebarry
·
3Comments
![first-timers[bot] picture](https://avatars.githubusercontent.com/in/4832?v=4&s=40)
first-timers[bot]
·
3Comments
milaaraujo
·
3Comments
milaaraujo
·
3Comments
Most helpful comment
I think there may have been a reversion in #2180 which affected @Gauravano's code in #2062:
https://github.com/publiclab/plots2/blob/ca820a87e083ed7aff95e6c903732d2d4fca7949/app/views/tag/_contributors.html.erb
It looks like
@noteCountwas changed to@note_countand I've reverted that in #2479. I want to add a functional test to ensure these are shown.