I've been organizing a more list-style planning issue here, with lots of related issues linked in and grouped; i'll try to organize that today! https://github.com/publiclab/plots2/issues/6801

I also wanted to point to this great resource on testing your work on the unstable server -- it's a great way to see how things run in an environment almost identical to the production server! https://github.com/publiclab/plots2/blob/master/doc/TESTING.md#testing-your-work-with-unstable

There are really a lot of different moving parts in this project, so please ask questions if you get lost or confused! Or see a way to do things that'd be better!

For example, here's an instance of using LEL within plots2 that isn't working correctly: https://github.com/publiclab/plots2/issues/6889

Ok great!

One question I have: in my proposal I have a plan for a new way of setting location on users profiles. Do you still want me to do this, even though it's not on the plots2 checklists?

Sure! I think we will all need to update/refine/revise project plans and I'd love to workshop a new design idea as part of it! Also, the listings I've added so far are by no means complete or comprehensive.

I wanted to share this "how we work" issue which is a bit dense but could have some useful info for you both: https://github.com/publiclab/plots2/issues/5667

OK, so @nstjean has identified a lot of great bugfixes and UI enhancements for location entry in Phase 1 - they all sound GREAT. Just be sure that the styling matches our style guide (esp the "Add a location" styling we've been trying to standardize - a white button with a red marker -- #6856) and the dashboard is about to be rebuilt #6787 but preserves a space for the Add your Location button there too. Let's start listing out those ideas/tasks in our checklist post at https://github.com/publiclab/plots2/issues/6801 and we can mark them done as we go!

@crisner has some awesome work planned for the layer selector/control/menu. I wonder if @crisner may want to prioritize the debugging of the search-for-location in the location selector (which uses this library: https://github.com/publiclab/leaflet-blurred-location) and the layers "browser" menu, based on the static HTML in https://github.com/publiclab/leaflet-environmental-layers/issues/232. One feature we are really interested in is a demo in the Github Pages demo which can generate an embed code -- basically as you pan and zoom and select and deselect layers, it would modify the URL hash, and you'd be able to get the URL from that. Both using a method like getUrlHash() within the library, and also in the UI. What's nice about this is that @sagarpreet-chadha has implemented this within the context of plots2 already, so that work could be back-ported to LEL, perhaps? https://github.com/publiclab/plots2/pull/6874

The reason I suggest this is that the layers selector is already at the beginning of your timeline @crisner and this would nicely tie together a number of adjacent and parallel projects. As you use the new menu, it also allows you to then copy that to display on another website, you know?

I also recommend that you each look through each others' proposals and think about how, as you get into the project, you might divide up the work for those middle sections which overlap most; for example, both of you have shared some really great UI mockups with ideas for where active layers might be displayed, and other elements. If we do a good job developing things in small modular pieces, we should be able to work in synchrony on these things.

Finally, one area where we might expand, given that we have 2 people working on this project now, is in testing -- both in plots2 and in the UI tests in LEL, some of which are here: https://github.com/publiclab/leaflet-environmental-layers/tree/master/spec/javascripts

These features are complex and deeply intertwined. We may gain a lot in stability if we protect the features (and bugfixes) with good tests, so I'd love to hear how you both might schedule time to build testing into your project plans! Here's an issue where we can get organized on this too: https://github.com/publiclab/leaflet-environmental-layers/issues/71

Thanks a lot, I know I've just shared a TON. Take your time processing this info, and please don't hesitate to ask questions, or point out where I've missed things or been unclear, or where you have new and great ideas to share!

🎉 Thanks so much for working with us!!!!!

Yes that sounds great!! I'm going to take time to go through all the different lists and proposals and @crisner and I will decide how to coordinate our efforts!

Thanks for laying out all the information @jywarren! I'll start by going through all the information and our project proposals. I'll make sure to ask if anything is unclear. I'll have a discussion with @nstjean and plan our work accordingly.

This is great..glad to work with you both..feel free to tag me incase of anything. Thanks

I also just added @crisner @nstjean to the @publiclab/soc team (which we use for various Summer of Code-style programs) which should give you considerably more access; to label, edit, and triage issues and pull requests! Welcome! 🎉

I have listed a few tasks below for now and have tried to link them with existing issues. Hope to finish laying them out by tomorrow according to the tasks in our proposals. @nstjean, please edit this to add the tasks you have laid out. @jywarren I have a few questions that I have included at the end.

[Natalie] We have added all items from our plots2 plan.

Plots2

All tasks for /map/ route are here: #6993

• [x] Map layer permalinks get overwritten on page open (issue #6889) PR#293

• [x] Add a zoom:xx power tag for map zoom along with lat and lon when saving location #7019 PR #7020

• [x] Enable embedded maps in wiki pages, notes and questions

• [x] Add prompt to Dashboard (/dashboard) to add user location, if user doesn’t have a location set.

• [x] Fix location input on /people/ #5882 PR https://github.com/publiclab/plots2/pull/6895

• [x] Fix location tagging in user profiles PR #6886

Update 'new post' location form:

• [x] Fix click-and-pan freezing error
• [x] Debug search-for-location in the location selector https://github.com/publiclab/leaflet-blurred-location/issues/214 and #6915
• [x] Update the styling based on Natalie's proposal #6968 PR #6969
• [x] Add default location of user's profile location, allow user to remove or change it #6946 PR #6957
• [x] Add check for zoom tag, if not present calculate zoom level from lat and lon and save zoom - included in https://github.com/publiclab/plots2/pull/6957

Project: Redesign of location popup modal

• [x] Create mockups and post images for feedback and approval https://github.com/publiclab/plots2/issues/7031

Natalie's proposal included a possible design for the user profile location entry, this will need to be posted and input gathered as to what is the best way to accomplish it, how it should function and look.

• [x] Update user profile location method - choose inline or popup modal - https://github.com/publiclab/plots2/issues/7031

Testing:

• [x] Fix New system tests fail due to timing issues #6904 PR #6951

PL.Editor

• [x] Save zoom in submitted data https://github.com/publiclab/PublicLab.Editor/issues/373 PR https://github.com/publiclab/PublicLab.Editor/pull/374

LBL

• [x] Add getZoom function https://github.com/publiclab/leaflet-blurred-location/issues/221 PR https://github.com/publiclab/leaflet-blurred-location/pull/223

• [x] Add getZoomFromCoordinates function https://github.com/publiclab/leaflet-blurred-location/issues/222 PR https://github.com/publiclab/leaflet-blurred-location/pull/224

• [x] Write tests for the new functions - included in PR https://github.com/publiclab/leaflet-blurred-location/pull/224

• [x] Add new functions to Readme API https://github.com/publiclab/leaflet-blurred-location/issues/225 PR https://github.com/publiclab/leaflet-blurred-location/pull/226

LEL

• [x] Work on embed feature PR#296

• [x] Make domain name as a settable option defaulting to the gh-pages PR#307

• [x] Display directions on top of map in the demo page PR#309

• [x] Replace leaflet layer control with the layers browser menu from the mockup in #232 PR#320

• [x] Collect urls for "requests" from layers if they are open to community submissions #138 PR#317

  • [x] Implement the report functionality on the layers browser menu for layers that accept reports like OdorLog PR#320

• [x] Clone demo page to embed.html so that actual embeds do not show the notice PR#311

• [x] Track the bounding box of each layer, and display only those which intersect with current view #117

• [x] Display "new items" mark in Layers menu when you enter an area with a new layer #133

• [x] Implement minimal mode as discussed in issue #123.

• [x] Show a button to toggle between default mode and minimal mode. :bulb:

  • [x] Implement a toggle function

• [ ] Display optional legends for each layer #103

• [ ] Stop displaying spinners if a layer fails to load for 10 seconds (issue #290)

• [x] Search not open by default but behind a magnifying glass icon that pops open PR#326

• [x] Implement a search functionality to search for a location to re-center upon with a search button and autocomplete geocoder(discussed in #134) PR#326

• [ ] Zoom in on map based on user location using geolocation.(wonder if this is useful as maps are displayed based on location entered by the user in plots2.) :grey_question:

• [ ] Implement a help functionality :bulb:

  • [ ] :bulb: Display option for users to file bug reports with the button directing users to a bug issue template

  • [ ] Option to request new layer that directs to an issue template. -> Layer submission process, per-layer metadata #135

  • [ ] :bulb: An option to display information about the different elements in the map's UI(may be helpful to new users) may be as a modal or a simple faq or as walkthrough tooltips that can be skipped.

• [ ] Implement a features menu that can toggle other elements in the map's interface individually(except layers menu) from view.(Not sure about the usefulness of this functionality other than having 'simple' and personalized interface but just putting out here as this seemed like a good idea at the time) :bulb:

• [ ] Create a function to make adding layers easier

  • [ ] Reduce redundant layer code. A member is working on a plugin that helps avoid repetetive code when adding new layers which is mentioned in #276. We could try to use this.

• [ ] Standard methods for each layer like layer.show() layer.hide() layer.isVisible() #251

• [ ] Create a layer name aggregator function #253

• [ ] Create an option to toggle overlapping marker spiderfier feature for individual layers :bulb:

• [x] Make layer names listing in README and layers hash strings consistent PR#315

• [x] Fix active base layer selection PR#300

• [x] Reformat/clean up code PR#303

Testing

• [x] Write tests for embed control PR#314

• [ ] Write UI tests

Questions

• What does 'share your own map data' on the layers browser menu do? Shown here in the mockup in issue #232.

• There was a mention on debugging of the search-for-location in the location selector. Is this for the 'Add location section' when adding a post?

• How should the layers 'browser' menu be implemented in LEL? My idea was to toggle it when clicking on the alert icon displaying the available layers.

• I had proposed some new features for the LEL UI in my project proposal. Do I include those too as tasks here?

• I am thinking of working on the embed feature and the layers menu for week one followed by writing tests for them. Are there tasks I should consider prioritizing over others?

Thanks. :-)

I've updated @crisner 's post above with some tasks that I had planned for plots2.

We had some overlap in LEL and we'll have to figure out who will take what! Also in the planning issue for geographic features for plots 2 there are more tasks for plots 2, and in the planning issue for LEL there are more as well. I created a large master-list of all the issues using a task planning tool to try to visualize them all. I sent the info over to @crisner so she can use it too. :)

One question I have is about the location tools in Plots2. I notice that in some places it uses the pop-up modal, such as in your profile when you are adding a location. But then when you are writing a new post or page it shows an in-line form.

1. Is there a reason for having two different location input forms?
2. Should we consolidate to just one or the other?

Hi all! Great questions, and great to hear from you all! I'll just jump right in:

What does 'share your own map data' on the layers browser menu do? Shown here in the mockup in issue #232.

Ideally it leads to a page which introduces LEL, and the lays out simple steps for suggesting/submitting a new layer idea (url, type, etc etc) so that we gradually add more layers. We don't yet have a simple way for non-developers to suggest layers, but we do have a new-layer label... in the meantime this could lead to a section of the README which we build out later.

There was a mention on debugging of the search-for-location in the location selector. Is this for the 'Add location section' when adding a post?

I think so! I saw a couple things - one, that it errors near the 360°/0° boundary https://github.com/publiclab/leaflet-blurred-location/issues/213 and one just about the modal being really slow to appear https://github.com/publiclab/plots2/issues/6897

How should the layers 'browser' menu be implemented in LEL? My idea was to toggle it when clicking on the alert icon displaying the available layers.

Yeah, i'm not 100% sure, and open to ideas. I think that the current layer selection control in upper right has little enough information as to be not really very useful. There's no extra info about each layer, they are obscurely named, etc etc. So, maybe the bigger menu would just replace it entirely, and toggle on as you click that button in the corner?

I had proposed some new features for the LEL UI in my project proposal. Do I include those too as tasks here?

That would be great, and can you highlight them specifically for feedback, too?

I am thinking of working on the embed feature and the layers menu for week one followed by writing tests for them. Are there tasks I should consider prioritizing over others?

This sounds pretty good! Also note the relation between generating an embed code and generating a plots2 short code, aka an "inline powertag" (which we use to embed maps in plots2, and is explained here: https://publiclab.org/wiki/inline-maps). These are very similar if not quite redundant, although we don't use iframes on plots2, which is nice. So, the function which generates the embed code could easily be replaced with one which generates a short code for plots2, you know?

And to @nstjean --

Is there a reason for having two different location input forms?
Should we consolidate to just one or the other?

They should share a lot and look similar, for sure! But one is for the discrete activity of adding a location, while the other we wanted to appear more clearly as one step in the flow of crafting a post, so we didn't want it to be in a popup modal. Does this make sense? And the one in the editor also has additional features such as being able to fetch default zoom and lat/lon coordinates from the URL parameters, kind of like how @nfarve is working on here: https://github.com/publiclab/plots2/pull/6858

I hope these help answer your questions! Please keep asking! Great day 1 😄 🎉

And to @nstjean --

Is there a reason for having two different location input forms?
Should we consolidate to just one or the other?

They should share a lot and look similar, for sure! But one is for the discrete activity of adding a location, while the other we wanted to appear more clearly as one step in the flow of crafting a post, so we didn't want it to be in a popup modal. Does this make sense? And the one in the editor also has additional features such as being able to fetch default zoom and lat/lon coordinates from the URL parameters, kind of like how @nfarve is working on here: #6858

That makes sense! I do think they need to look more similar, I'd love to style the popup modal version to look more like the inline version.

sure, want to share a mockup in an issue in
https://github.com/publiclab/leaflet-blurred-location/ ?

On Tue, Dec 3, 2019 at 3:36 PM Natalie St Jean notifications@github.com
wrote:

And to @nstjean https://github.com/nstjean --

Is there a reason for having two different location input forms?
Should we consolidate to just one or the other?

They should share a lot and look similar, for sure! But one is for the
discrete activity of adding a location, while the other we wanted to appear
more clearly as one step in the flow of crafting a post, so we didn't want
it to be in a popup modal. Does this make sense? And the one in the editor
also has additional features such as being able to fetch default zoom and
lat/lon coordinates from the URL parameters, kind of like how @nfarve
https://github.com/nfarve is working on here: #6858
https://github.com/publiclab/plots2/pull/6858

That makes sense! I do think they need to look more similar, I'd love to
style the popup modal version to look more like the inline version.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6J5MKFQ5EZBJDJNOPVTQW27KHA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF2XJSA#issuecomment-561345736,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J3IATZZZW4YPYI234DQW27KHANCNFSM4JTZOL5A
.

Ok, I'll work on a mockup.

Another question while I'm thinking about it.

Our original proposals had a timeline with tasks scheduled for each week. This is good for accountability and mentors making sure we are on track. With two of us working on the same large project would you rather we assign the tasks now while we plan, so we know who is in charge of what? Or would you prefer us if we worked through the list together, doing whatever task is next on the list?

One can write the code and other can test that code. This will enable
better tests and better code. Like crisner wrote function A and nstjean
wrote tests for A. Then crisner wrote tests for function B written by
nstjean. This will encourage pair programming too.
Just a suggestion. Thanks

On Wed, 4 Dec 2019, 8:36 am Natalie St Jean, notifications@github.com
wrote:

Another question while I'm thinking about it.

Our original proposals had a timeline with tasks scheduled for each week.
This is good for accountability and mentors making sure we are on track.
With two of us working on the same large project would you rather we assign
the tasks now while we plan, so we know who is in charge of what? Or would
you prefer us if we worked through the list together, doing whatever task
is next on the list?

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AFAAEQY62FEVTDVXZFGWUHTQW4NDJA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3SEAI#issuecomment-561455617,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAAEQZ4HQEVGK3WQAMFAT3QW4NDJANCNFSM4JTZOL5A
.

@nstjean I have updated the list.

@jywarren I have updated the task list. The ones with the :bulb: emoji are the new features I had mentioned. Would like your feedback on implementing them.

Would also like your feedback on the task below.

Zoom in on map based on user location using geolocation.(wonder if this is useful as maps are displayed based on location entered by the user in plots2.) :grey_question:

Another question. There are some tasks on the list which do not have their own issues. Do we create an issue for them before we begin working on those tasks?

@nstjean and I have organized the tasks together. We will be dividing up tasks as we go.

Will we need to post a week-by-week timeline of the tasks, as in our original proposals?

Will we need to post a week-by-week timeline of the tasks, as in our original proposals?

Like, an updated timeline? do you think this would be useful for you both?

Zoom in on map based on user location using geolocation.(wonder if this is useful as maps are displayed based on location entered by the user in plots2.)

I think the idea here was just that if you've entered a location, we should also try to show it at an appropriate level of zoom, not just the whole world, centered on your location. When people put in locations, they often do so to a specific resolution/blur-level, because we use this kind of cool library we developed: https://github.com/publiclab/leaflet-blurred-location#how-it-works -- so, the precision of the lat/lon coordinates can be used to indicate a zoom level.

Another question. There are some tasks on the list which do not have their own issues. Do we create an issue for them before we begin working on those tasks?

Yes please! What typically works is to make a list-style "planning issue" at first with checkboxes, and to split out just a few into their own issues, which you'll tackle first. Then spin out more separate issues as you go. This helps to not create a flood of issues all at once at the beginning, and if plans change as we learn more, we don't have to close a bunch of issues, we can just adjust the plan and those issues we have created so far. Thanks, i hope this makes sense!

Our original proposals had a timeline with tasks scheduled for each week. This is good for accountability and mentors making sure we are on track. With two of us working on the same large project would you rather we assign the tasks now while we plan, so we know who is in charge of what? Or would you prefer us if we worked through the list together, doing whatever task is next on the list?

This is partly up to you, in terms of what you both prefer. We don't have a strong preference and we will be paying enough attention to be aware of how you both split up the work, so we're not too worried about accountability in that regard. If it were me, I'd split up the next couple weeks worth of work at a pretty high resolution, so you don't step on each others' toes, but just have a more general idea of division of labor further out. And just check in every week to be sure you have the next couple weeks planned out sufficiently.

We're a very cooperative community and while we appreciate independence, we are most interested in how community members support each other and rely on each others' complimentary and distinct skill sets. People have preferences on the kind of work you like to do, what you're good at, what you want to get better at, and what you enjoy offering support on (if you know a skill set very well). So, these factors may guide you in deciding who works on what parts.

If you find that you need some support in making these decisions, I and the other mentors are happy to chime in with advice or guidance. So just reach out!

Thanks, sorry this was a long response!

Finally, i do want to recognize that since the project has progressed since the original proposals were made, you're already integrating new tasks that hadn't existed in your original plans. We appreciate this! But I'm talking with some community members about getting involved in coding some parts of these too, so that there's enough capacity to accommodate the new tasks. No decisions just yet but I hope this will help you not feel overwhelmed!

Thanks so much @jywarren !

Will we need to post a week-by-week timeline of the tasks, as in our original proposals?

Like, an updated timeline? do you think this would be useful for you both?

I don't think it matters to us either way. Having a big list and just going through the items works just as well, that's how I worked on my personal project site... very long list of to-do items and just did them one at a time. :) I just wanted to know if there was a requirement for a timeline.

I like your idea of splitting up a couple weeks worth of tasks and then checking in and supporting each other as we go through them.

Pining this issue!

Hey @nstjean @crisner ,

First of all _congratulations_ for getting selected as outreachy interns 🙌 (i hope i am not late in wishing 😄 ).
I would like to officially introduce myself because i would be mostly working with you guys as mentor 🎈 . So i am one of the contributors at PL and have been doing so for more than 2 years i think. I started as a GSoC student and now i am mentoring various open-source programs including GSoC, GCI and Outreachy. I started the LEL project during my GSoC and have been actively maintaining it and would love help from you both to add more awesome features into LEL with the guidance of @jywarren and @ebarry !!!

Thanks!
Best,
Sagarpreet

Thanks @sagarpreet-chadha ! That is so cool that you started LEL during your GSoC. :) I look forward to working with you!

Thanks, @sagarpreet-chadha! I look forward to working together with your continued guidance and support! :)

Hey @crisner , @nstjean
Can you guys add the PR's that you want me to review or debug in this issue, I am getting a lot of emails lately and hence may miss some notifications. It would be easier for me to just come to this issue. Thanks 😄 !

Thanks, that's also great for overall project management. As we crank through issues, we should keep good track of what we've done or not. This can be done in a checklist that:

• [ ] can
• [x] be
• [ ] checked off

Another way (although i think pinging in this thread would also need to happen) is to maintain GitHub Project boards. But I think i remember you'd set up a project tracking system already? Maybe my memory today is playing tricks on me though 😄

Sorry just to clarify, if you use the checkboxes method, it doesn't send an email to Sagarpreet, so that's a good reason to leave a comment TOO if you're going to use the checkbox list you've made above. Thanks!

Ok that works! I'll be using the checkboxes above to track what is complete
and not, we can leave a comment with a link to issues so you both get
notified. I'm guessing editing the list isn't going to notify you?

>
Yes, we are using Notion to coordinate and organize our issues!

Oh cool, great. If you'd like to share a link that's great, but not
required! Thanks!

On Wed, Dec 11, 2019 at 2:57 PM Natalie St Jean notifications@github.com
wrote:

Ok that works! I'll be using the checkboxes above to track what is complete
and not, we can leave a comment with a link to issues so you both get
notified. I'm guessing editing the list isn't going to notify you?

>
Yes, we are using Notion to coordinate and organize our issues!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6J6IUAZV4OHXY3DSCFTQYFA2BA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUL6WI#issuecomment-564707161,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6JYPGCXV2YXTBDXXADLQYFA2BANCNFSM4JTZOL5A
.

@sagarpreet-chadha, I would like your feedback on this PR #296 for issue #252 on LEL. Thanks!

@sagarpreet-chadha PR #293 for issue #6889.

Feedback needed: https://github.com/publiclab/plots2/issues/6946

PR #6957 for #6946 - Included some ideas/suggestions.

PR #300 for issue #299 (Continuation of PR #296)

Yes going through the PR's now.

Hey @crisner , i have left a small change in your PR. After doing that we can merge that PR in LEL.
Which issue are you planning to do after that?

Hey @nstjean ,
I think you can do a small change that @jywarren has left in https://github.com/publiclab/plots2/pull/6858 so that you can work further in issue #6957 .

Thank you both!!! You both are doing amazing jobs 🙌 !!!

Thanks, @sagarpreet-chadha! I was working on issue #301. After this I was planning to work on making domain name as a settable option defaulting to the gh-pages as suggested while working on the embed feature. I was also looking into adding some tests.

Feedback needed for PR #303 on issue #301

Feedback needed for PR #300 for issue #299 updated with changes from PR #296. Thanks!

@sagarpreet-chadha, I need your guidance on the following issues I created. Would you take a look at it and let me know if I need to add or remove anything? Here are the issues: issue #304, issue#305, and
issue #6978. Thanks!

Hi all! I know many folks celebrate holidays in the coming weeks, not to mention New Year's. Please reach out on our mentor email threads about your availability and time you'll be taking off (please do!) so we're all synced up and aren't bothering one another while offline with family and friends 😄 🎉 🎆

Hey @crisner , the FTO issues looks amazing!!! Next time in LEL as well we can use the same FTO issue template of plots2. Thanks!

Ok I set this to allow public viewing! Hopefully it works correctly. This is our Notion project planner.
https://www.notion.so/nstjean/df760cb3a7514788bf448ce6f6d2404a?v=77cad99bbb0c4151965fe98c47d6499c

@jywarren For the item "Redirect /maps to /map, leave /archive as archive" -- does /map exist yet? Are we just moving over /maps to a different url?

It doesn't yet exist! I think @sagarpreet-chadha had possible started on
that, but we'll be needing:

1. a new route at /map/ and /map/:slug
2. a new page with a full screen map
3. a variety of permalink setup to display the correct locations

@sagarpreet-chadha, maybe you can update us on the latest on this so we can
start breaking it up into parts? If you've already started perhaps we can
merge some subset? Thanks!

On Mon, Dec 16, 2019 at 2:31 PM Natalie St Jean notifications@github.com
wrote:

@jywarren https://github.com/jywarren For the item "Redirect /maps to
/map, leave /archive as archive" -- does /map exist yet? Are we just moving
over /maps to a different url?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6J7PULTKWGWIZ75HQ7DQY7JSXA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG72NGA#issuecomment-566208152,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J75QMNSU7J7X362XI3QY7JSXANCNFSM4JTZOL5A
.

Ok great! Breaking it up will be excellent. I'll wait to see what has been
started, if anything, and go from there! I notice a lot of things on the
plots2 list revolve around having the map page working.

>

Hey @jywarren , @nstjean
It has been implemented by me 😄 !

I had implemented a new route /map with a full screen map with URL Hash implemented. Check this link:

https://publiclab.org/map/mapknitter#lat=60.23981116999893&lon=5.976562500000001&zoom=4

There is one bug which you can see when you open this page, the bottom partial of application.html.erb is overlapping with the map (this bug is not reproducible on local i guess ).

In PR https://github.com/publiclab/plots2/pull/6874 , i had implemented this new route /map with full screen map and working URL hash. This page was implemented so that iFrame can be used to embed this map to other websites. Thanks!

Feedback needed for PR #307 for issue #306. Thanks!

@sagarpreet-chadha, thank you for reviewing and approving the above PR today. I also need feedback for PR #309 on issue #308. Thanks!

Hey @crisner , the FTO issues looks amazing!!! Next time in LEL as well we can use the same FTO issue template of plots2. Thanks!

Thanks, @sagarpreet-chadha! I can edit the issues to use the template in plots2, if that's alright.

@sagarpreet-chadha That looks excellent!! I believe the footer is the part that's overlapping... it doesn't show up on local because the content doesn't exist on local. I haven't looked to see if it's a wiki or something else. I'm sure that's easily hidden via css for the map page.

Awesome @sagarpreet-chadha !!! Let's spin out a new issue with the next to-dos on that. Great!

I pulled a bunch out of https://github.com/publiclab/plots2/issues/6801 and moved them into a more specific issue here: https://github.com/publiclab/plots2/issues/6993

I hope that's helpful; happy to adapt if you want to organize differently. I'm also going to go in and check off a number of these that seem like they're completed from #6801!

Yes @nstjean , i believe position:absolute should do the trick. Thanks!

This PR should be good to go: https://github.com/publiclab/leaflet-blurred-location/pull/223

And this one too: https://github.com/publiclab/leaflet-blurred-location/pull/220

PR #311 on issue #310 ready for review.

I've run into a bit of a problem! The changes that I have made in leaflet-blurred-location are needed for me to complete the next steps in PublicLab.editor and plots2. How can I get the changes to show up? Is there a way to link my different repositories? Do we need to update something in LBL so that the changes show in PL.editor? I'm not really sure how to tackle this!

Ah! Ok so we need to increment the npm version number in the package.json
file in the library, then I or Sagarpreet needs to publish the new version.
Then running npm install or npm update in the downstream library will pull
the new version! Is the upstream library ready to publish? Thanks!!

On Wed, Dec 18, 2019, 2:05 PM Natalie St Jean notifications@github.com
wrote:

I've run into a bit of a problem! The changes that I have made in
leaflet-blurred-location are needed for me to complete the next steps in
PublicLab.editor and plots2. How can I get the changes to show up? Is
there a way to link my different repositories? Do we need to update
something in LBL so that the changes show in PL.editor? I'm not really sure
how to tackle this!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6JZWENGUCIJTSV7OJD3QZJX6TA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHESKY#issuecomment-567167275,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6JYBNTLQQ5DQDLYEHK3QZJX6TANCNFSM4JTZOL5A
.

Ah! Ok! This is the last big thing I need to get published to then make changes in the other repos: https://github.com/publiclab/leaflet-blurred-location/pull/224

Fantastic. And, there is a set of rules at semver.org for how we manage
version numbers; the short version is that a bugfix would trigger an
increase of +0.0.1, while a new feature is a "minor" +0.1.0 version change,
and if we had to make a breaking change that downstream users would need to
refactor around before updating, it'd be a "major" release of +1.0.0.

This is a cool system for coordinating releases between libraries! Hope it
makes sense!!!

On Wed, Dec 18, 2019, 2:28 PM Natalie St Jean notifications@github.com
wrote:

Ah! Ok! This is the last big thing I need to get published to then make
changes in the other repos: publiclab/leaflet-blurred-location#224
https://github.com/publiclab/leaflet-blurred-location/pull/224

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6J4YBGMZH6MNAGR7SLLQZJ2ELA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHGIYY#issuecomment-567174243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J5CTEY22HNNAYZNHJ3QZJ2ELANCNFSM4JTZOL5A
.

Ahhh, so this would be considered a "minor" feature?

Yes, that's correct!

On Wed, Dec 18, 2019, 3:00 PM Natalie St Jean notifications@github.com
wrote:

Ahhh, so this would be considered a "minor" feature?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6JZDFSG2WTIIX5ZOKNDQZJ54TA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHJOEA#issuecomment-567187216,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J73ZJL26U6MH6X4YWDQZJ54TANCNFSM4JTZOL5A
.

I've updated the version, fixed the error that was happening, and added tests. It's ready to merge! https://github.com/publiclab/leaflet-blurred-location/pull/224

Feedback needed for PR #314 on issue #313

Feedback needed for PR https://github.com/publiclab/plots2/pull/7020 for issue https://github.com/publiclab/plots2/issues/7019

https://github.com/publiclab/leaflet-blurred-location/pull/220 is approved and needs to be merged

Feedback needed for PR https://github.com/publiclab/PublicLab.Editor/pull/374 for issue https://github.com/publiclab/PublicLab.Editor/issues/373

PR https://github.com/publiclab/plots2/pull/6957 has been updated with the changes in LBL and should be ready to go merge now.

I've updated the list above with this weeks PRs. 🎉

@sagarpreet-chadha, the PR for issue #6978 shows errors as LEL is not updated in plots2. Do I need to update the npm version with '+0.1.0' as discussed in the conversation above or should we put it on hold for now?

PR #315 for issue #297 ready for review.

While working on issue #297, I found the documentation for windrose layer to be a bit unclear here:
https://github.com/publiclab/leaflet-environmental-layers#to-use-wind-rose-layer-

I was wondering if it would be better for clarity if it could be added as the first step before initialization here?:
https://github.com/publiclab/leaflet-environmental-layers#real-time-layers-

Need review/merge for Issue https://github.com/publiclab/leaflet-blurred-location/issues/225 PR https://github.com/publiclab/leaflet-blurred-location/pull/226

I also posted some ideas for the popup modal https://github.com/publiclab/plots2/issues/7031 looking for feedback!

I'll try to respond a bit more today although I'm getting into holiday
travel mode :-P sorry!

Regarding npm version bump, yes! That'd be great.

And if you have a PR ready for merge please note this in the comments under
the PR and after reviewing I can go ahead and do it! Thanks!

On Mon, Dec 23, 2019, 10:27 AM Natalie St Jean notifications@github.com
wrote:

Need review/merge for Issue publiclab/leaflet-blurred-location#225
https://github.com/publiclab/leaflet-blurred-location/issues/225 PR
publiclab/leaflet-blurred-location#226
https://github.com/publiclab/leaflet-blurred-location/pull/226

I also posted some ideas for the popup modal #7031
https://github.com/publiclab/plots2/issues/7031 looking for feedback!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6J4J3OFPHRRUPHIJ7VDQ2DKGHA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRK6JY#issuecomment-568504103,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J3QIYDCSGPHX3I7M3DQ2DKGHANCNFSM4JTZOL5A
.

No worries! Enjoy your time away!! I'll be offline the next two days with holiday celebrations too.

PR #317 for issue #316 ready for review. I have bumped the version in this one.

I'll try to respond a bit more today although I'm getting into holiday
travel mode :-P

No problem! Take your time. Enjoy your holidays! Have fun!

I was wondering if it would be better for clarity if it could be added as the first step before initialization here?:

Yes makes sense!

Reviewed all PR's :)

Need some feedback for this PR #320. It is still a work in progress but I would like some input on it. Thanks!

I made changes to PR https://github.com/publiclab/leaflet-blurred-location/pull/226 :)

Hey @nstjean , I have merged the above PR :) what are you working on now?

@crisner , you may continue work on Control Bar in LEL. We can have @jywarren later give comments whether we want new UI for small maps or not.

Thanks both!!! 😄

Excellent! Next I'm going to be working through the list on #6993 - first I'm fixing the map error and then displaying the footer properly.

Fixing the route/default values for /map/ - Issue https://github.com/publiclab/plots2/issues/7045 PR https://github.com/publiclab/plots2/pull/7046 - ready for review/merging

WIP, Push the footer below map in /map/ - Issue https://github.com/publiclab/plots2/issues/7047 PR https://github.com/publiclab/plots2/pull/7048

I posted 2 FTOs: https://github.com/publiclab/plots2/issues/7050 and https://github.com/publiclab/plots2/issues/7051

Need input on this bug, map allows scrolling out of bounds and is saving incorrect longitude: https://github.com/publiclab/plots2/issues/7052

Posted an FTO in LEL, issue #322

PR#319 for FTO issue#305 ready.

PR #320 ready for review.

Meanwhile, I plan to work on writing tests for the same. The other tasks I had planned to work on after this are,

• Display "new items" mark in Layers menu when you enter an area with a new layer #133
• Track the bounding box of each layer, and display only those which intersect with current view #117 - I believe this is addressed in the above PR.
• Search not open by default but behind a magnifying glass icon that pops open
• Location search: use autocomplete decoder and re-center map

I need some input on #7048

Stop scrolling out of bounds: Issue #7052 PR #7058

Make /map/wiki_slug routes that source lat/lon/zoom from matching wiki page - Issue #7060 PR #7061 - WIP

Next up:

• Add “View map” button to geotagged page sidebars, opening /map/SLUG for wikis, and /map#zoom/lat/lon permalink for notes
• get notes, wikis, and people all showing on /map/SLUG pages
• Slider in LBL does not update when map is used to zoom in and out
• Permalinks on /map/ should show current location in URL hash even when using default data

Happy new year everyone :)

I have reviewed the above PR's. Thanks!

For some reason, I am unable to instantiate the new layer control in Jasmine. There seems to be some issue with L.Control.Layers extended classes. Leaflet classes extended from L.Control(ex. embedControl) seems to accessible in the test files. I tried setting up karma with jasmine and it seems to be working but I am having trouble with loading fixtures. I will give it another go and share my PR if I am still stuck.

I need some clarifications in the following tasks:

• Track the bounding box of each layer, and display only those which intersect with current view #117
• Display "new items" mark in Layers menu when you enter an area with a new layer #133

I will be working on the search control in the meantime.

Needs review: Add zoom override to maps in sidebar and top of page: Issue #7077 PR #7078

7048 is ready to merge

7046 should be ready to merge, the requested changes are made in #7061

I have some questions in https://github.com/publiclab/plots2/issues/7052

These two items have been added to #7061 :

• Add “View map” button to geotagged page sidebars, opening /map/SLUG for wikis, and /map#zoom/lat/lon permalink for notes
• Permalinks on /map/ should show current location in URL hash even when using default data

I need some help with PR #328 related to testing layersBrowser.js. Thanks!

PR #326 for issue #325 ready for review.

Updated above list with PRs.

PR #329 ready for issue #327

I will be working on issue #87 next.

Awesome!!!

On Mon, Jan 6, 2020 at 9:14 AM Renisha Christie. A notifications@github.com
wrote:

I will be working on issue #87
https://github.com/publiclab/leaflet-environmental-layers/issues/87
next.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6J2AVCAIVW42QZSMEPLQ4M4GDA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFRUPY#issuecomment-571152959,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6JZRV6YNMI7MIMYANKLQ4M4GDANCNFSM4JTZOL5A
.

Tag me in on Gitter if you need any help!

On Mon, Jan 6, 2020, 8:47 PM Jeffrey Warren notifications@github.com
wrote:

Awesome!!!

On Mon, Jan 6, 2020 at 9:14 AM Renisha Christie. A <
[email protected]>
wrote:

I will be working on issue #87
https://github.com/publiclab/leaflet-environmental-layers/issues/87
next.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6J2AVCAIVW42QZSMEPLQ4M4GDA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFRUPY#issuecomment-571152959
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAAF6JZRV6YNMI7MIMYANKLQ4M4GDANCNFSM4JTZOL5A

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AJXHQZ7ICNM4G7P6Z23NR7TQ4NDP3A5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFXSLQ#issuecomment-571177262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJXHQZ6ERNXZ64573UNHJMLQ4NDP3ANCNFSM4JTZOL5A
.

Sure @IshaGupta18! Thanks!

I have WIP https://github.com/publiclab/plots2/pull/7125 - not done, but can give feedback!

https://github.com/publiclab/plots2/pull/7061 is frustrating me. I fixed the one test that was failing, but it's getting timing errors on all my maps tests.

https://github.com/publiclab/plots2/pull/6957 is all set to merge

https://github.com/publiclab/plots2/pull/7105 change was made, should be all set to merge

I created two issues that are not too difficult problems for anyone who is looking for a small issue to tackle.
https://github.com/publiclab/plots2/issues/7122
https://github.com/publiclab/plots2/issues/7120 - Well, this one I'm not sure about. Might end up being more complicated, but I have a feeling it's something silly. If no one else shows an interest then I'll figure it out.

Next up is going to be adding notes, wikis and people on the /map/ with popups.

Thanks @IshaGupta18 !

@jywarren, inputs needed for PR #330. Thanks!

PR #330 for issue #87 is ready. Thanks!

• PR #332 ready for review
• Created an FTO with issue #333

PR #340 for issue #338 ready for review

@jywarren, Please take a look at PR #7157

PR https://github.com/publiclab/plots2/pull/7159 is ready for review and merging

PR https://github.com/publiclab/plots2/pull/7061 will just not pass travis on the server with the map system tests I wrote, though it passes on my local env. Cess is taking a look.

PR https://github.com/publiclab/plots2/pull/7125 is still a work in progress. :)

Issue https://github.com/publiclab/plots2/issues/7084 I need feedback before I start.

Posted FTO issue #7217. This would resolve 404 issues from embed code copied from https://publiclab.org/map/

• Need inputs for Issue #7220 and Issue #344
• PR#343 ready for review

Next up on my list:

• Implement minimal mode #123

@nstjean, I have left a comment for you here: #6969. Could you take a look at it? Thanks!

PR #345 for issue #337 ready for review.

@crisner , this one is interesting to solve https://github.com/publiclab/leaflet-environmental-layers/issues/123 , we can discuss the approach before jumping to code. What do you think?

@nstjean ...Before @jywarren does next deployment, can you do the changes requested here: https://github.com/publiclab/plots2/pull/6969 .

Great work :)
Thanks!

@sagarpreet-chadha I made the requested changes in that PR before merging... am I missing something that didn't get changed?

@crisner , this one is interesting to solve publiclab/leaflet-environmental-layers#123 , we can discuss the approach before jumping to code. What do you think?

Sure, @sagarpreet-chadha! I was thinking we need to check which type of marker would be 'light' on the page. I was wondering if it would be better to change all markers to leaflet shapes, for example the circleMarker or like what Jeff used in unearthing-pvd, I think it was done using glify. We would have to add the minimal mode icon for all the layers and render them according to the mode the user has set on the map. Do you have any ideas that you would like to share?

I also wanted to suggest that the new menu @crisner is working on could be featured on the new /map page shown here:

https://stable.publiclab.org/map

...with all layers available. That'd be really nice place to feature this new work! What do you think?

Yes! That would be super exciting!

I have a couple questions on https://github.com/publiclab/leaflet-blurred-location/pull/232

PR#346 for issue#344 ready for review

Need inputs on issue#347

https://github.com/publiclab/leaflet-blurred-location/pull/232 is ready for merging.

And once that's merged and published I'll be able to use it to finish https://github.com/publiclab/plots2/pull/7125

https://github.com/publiclab/plots2/pull/7189 is ready to merge

https://github.com/publiclab/plots2/pull/7222 is ready to merge

Thanks all! Going through some now!

On Wed, Jan 15, 2020 at 9:44 AM Natalie St Jean notifications@github.com
wrote:

7189 https://github.com/publiclab/plots2/pull/7189 is ready to merge

7222 https://github.com/publiclab/plots2/pull/7222 is ready to merge

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6J7PRXBZNJTBXW6TST3Q54N37A5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJAQ3NI#issuecomment-574688693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6J3MTKBV2XYKVVB5YYTQ54N37ANCNFSM4JTZOL5A
.

Need feedback on PR #352 for issue #349.

Regarding popups not showing on markers:

If we change this line popup = new Popup(options).setContent(popup); to popup = new Popup(options).setContent(popup._content ? popup._content : popup); in leaflet repo line:

https://github.com/Leaflet/Leaflet/blob/d1a1e97b8290f642eb677284af53c2db64199a76/src/layer/Popup.js#L320

Everything works fine then!

One way to change this line is to use https://www.npmjs.com/package/patch-package , this changes that line in node modules folder after we do yarn install. The advantage is that we can still update leaflet version if there is any (we will kind of become static user of leaflet if we fork leaflet and do this change).

Good night guys!

oh goodness, i totally misunderstood, please forgive me @sagarpreet-chadha ! It's a Leaflet bug? I guess I'd prefer to fork Leaflet and fix it and point to our branch, but is it a known issue, that might be fixed by them soon? Or, is there any way for us to override this line in our code, after including Leaflet?

@crisner @nstjean what do you think? I guess we should not hold back the publication of PublicLab.org if we don't have a quick path to fix this yet. I'm opening an issue where we can discuss this a bit more, would love to hear from you. Thanks!

Can we create a pull request on Leaflet for the fix so it gets pushed through by them? I'm curious, did the popups used to work and now they don't? Or was this an ongoing issue?

I think we need to collect up some more background on the state before and
the state now, and when it happened, and collect it in the new issue I
made, before making a final decision. Thanks!

On Fri, Jan 17, 2020 at 2:15 PM Natalie St Jean notifications@github.com
wrote:

Can we create a pull request on Leaflet for the fix so it gets pushed
through by them? I'm curious, did the popups used to work and now they
don't? Or was this an ongoing issue?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=AAAF6JZADIQOCNTMHKDZPZDQ6H7BVA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIVSZI#issuecomment-575756645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAF6JYUHJ26E5O2XWMB57DQ6H7BVANCNFSM4JTZOL5A
.

PR#353 for issue#347 is ready.

I'm so excited that yesterday I had success with the Jasmine tests! That was a long few days of repeated trial and failure.
https://github.com/publiclab/leaflet-blurred-location/pull/235 is LBL's fix
https://github.com/publiclab/leaflet-blurred-location-display/pull/93 is LBLD's fix - might not be needed
And today I'm going to look at LEL and the People layer test failures. I'm betting it's related.

Not yet ready but would like some feedback on PR#356 for issue#123. Thanks!

I added a fix for LEL https://github.com/publiclab/leaflet-environmental-layers/pull/358 - might not be needed

Commented/reviewed above PR's :)

I also could use feedback here: https://github.com/publiclab/leaflet-blurred-location/issues/233#issuecomment-576752535

Requested changes made for PR#353 for issue#347 and is ready for review.

I would also like some inputs on PR#356

Question about the map page here: https://github.com/publiclab/plots2/issues/6993#issuecomment-577352894

Adding PLpeopleLayer to LEL: https://github.com/publiclab/leaflet-environmental-layers/pull/361 [WIP]

https://github.com/publiclab/leaflet-blurred-location/pull/235 ready for merge

Reviewed above PR's. Thanks!

On Thu, 23 Jan 2020, 01:28 Natalie St Jean, notifications@github.com
wrote:

Question about the map page here: #6993 (comment)
https://github.com/publiclab/plots2/issues/6993#issuecomment-577352894

Adding PLpeopleLayer to LEL: publiclab/leaflet-environmental-layers#361
https://github.com/publiclab/leaflet-environmental-layers/pull/361 [WIP]

publiclab/leaflet-blurred-location#235
https://github.com/publiclab/leaflet-blurred-location/pull/235 ready
for merge

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/6887?email_source=notifications&email_token=ADSCRRPLFK5SMXGK32SZVBDQ7CQOBA5CNFSM4JTZOL5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJU423A#issuecomment-577359212,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSCRRPCX2YPMQEJCPB4GGDQ7CQOBANCNFSM4JTZOL5A
.

PR#356 for issue#123 ready for review. Thanks!

publiclab/leaflet-blurred-location#235 - ready for merge

https://github.com/publiclab/leaflet-environmental-layers/pull/361 - ready for merge

https://github.com/publiclab/plots2/pull/7358 - should be ready, travis failed and needs to be restarted

Would like feedback in LEL:
https://github.com/publiclab/leaflet-environmental-layers/issues/364
https://github.com/publiclab/leaflet-environmental-layers/issues/365

There appears to be an error happening on some wiki pages - looks like just ones with an inline map. It's preventing use of the "add a location" button. I'll be looking at it more in depth tomorrow: https://github.com/publiclab/plots2/issues/7346

Feedback needed for PR #367

Thanks all! Looked through these!

https://github.com/publiclab/leaflet-blurred-location-display/pull/95 - bumps LBL, ready for merge

https://github.com/publiclab/leaflet-environmental-layers/pull/368 - bumps LBL and also bumps the version number for LEL so that the changes can get pushed down to plots2. Ready for merge.

The following PRs are ready to be reviewed and merged

• PR#373 for issue#372
• PR#375 for issue#374

PR#380 for issue#379 ready for review.

https://github.com/publiclab/plots2/pull/7425 ready for review and merge

I'm going to close this up since the process has moved to #7432 !!! Thanks, all!