The underlined link text in the sidebar that indicates that there are a certain number of additional tags on a piece of content is clickable, but is not actually a link
What did you expect to see that you didn't?
I expected that this would expand to show existing tags.
Using the "circle +" does serve to expand and show the tags AND provide the add a tag box, so the functionality is still available, which is good.
However, the broken link should be fixed.
https://publiclab.org/questions/jeffkrol/09-29-2020/using-thunderoptics-spectrophotometer
This can help us diagnose the issue:
liz
Can I work on this?
Go ahead @swarajpure. Thanks.
The file that renders this tag sidebar is https://github.com/publiclab/plots2/blob/main/app/views/tag/_tagging.html.erb
Thanks @swarajpure !
Feel free to ask any questions, i may not have described the issue very well.
Clicking the underlined text is supposed to show the blue lozenges of the tags. Then clicking the "circle+" is supposed to open the input box to add more tags. This is right, isn't it @jywarren ?
Thank you @ebarry !
Do I necessarily have to have linux environment for ruby? I use windows.
@swarajpure nope, we do have windows installation guidelines here https://github.com/publiclab/plots2#windows-installation do let us know if you are having any trouble with the installations. Thanks
I guess I will pass this one. Commenting myself so that somebody else can take it up and fix it instead of you guys waiting up for me. Didn't wish to ghost.
Sorry for the inconvenience caused.
no worries, thanks @swarajpure
Hi all! this could make a pretty good first-timers-only issue -- the code for the link itself is here:
And, the JavaScript which opens the extra tags was modified recently, so we just need to change the selector
to include the text link too, so I think it would be:
$("#tags-open, .show-more-tags").click(function(){
This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!
Hi all. I wanted to note that this broken link is especially troublesome if you’re not logged in to the website, as I’m only able to see the functional “+” button if I’m logged into Public Lab. So for food who may not have a username, they’re unable to access any tags that are in the collapsed menu.
Hi, just noting this was solved in https://github.com/publiclab/plots2/issues/8571 by @nk183 in a first-timers-only issue created by @Cadreia -- thank you all!!!
Most helpful comment
Hi all. I wanted to note that this broken link is especially troublesome if you’re not logged in to the website, as I’m only able to see the functional “+” button if I’m logged into Public Lab. So for food who may not have a username, they’re unable to access any tags that are in the collapsed menu.