Rollup-plugin-typescript2: Does not work with plugin which containing async/await syntax

I added a workaround to ignore anything object-hash can't process (see objecthash branch, objectHashIgnoreUnknownHack option). This can potentially make cache stale though, so not a good long term solution.

@wessberg

I must admit I'm surprised this haven't been more of an issue so far since async functions are extremely common by now 😀. Which is also why I think that simply ignoring it will lead to a great deal of cache issues. The PR I submitted to object-hash some time ago was a consequence of this very issue, and I would suggest that you remove the dependency on object-hash. I'm pretty confident that the PR submitted some time ago would work just fine since it matches on the same value as provided in the error message and passed both unit tests and solved the issues in this plugin, so feel free to depend on the PR rather than the NPM package here.

@vwxyutarooo, an immediate workaround is to set clean: true in the config to bypass the cache completely. Alternatively (sorry for the plug) I built https://github.com/wessberg/rollup-plugin-ts which will also work just fine

@wessberg Yeah, I guess not many rollup plugins have async in their interface yet.

Do you know a better way of hashing objects? I need to create a cache key based partly on rollup configuration object (and therefore containing source of all the plugins used) that is passed in on startup.

btw, to clarify -- the problem applies to async stuff in rollup config itself. Async in the code being transpiled is not a problem, because code is hashed based on source text.

Hmm, well, you could apply sha1 to the result of JSON.stringify'ing the entire config with a custom replacer that maps plugins to their name property which I'm pretty sure is required.
For example, the following rollup config:

{
  // ...
  treeshake: true,
  plugins: [
    myPlugin1(),
    myPlugin2()
  ],
  // ...
}

Could be converted into the following JSON representation:

{
  "treeshake": true,
  "plugins": [
    "name-of-my-plugin-1",
    "name-of-my-plugin-2"
  ]
}

And then you could apply sha1 and get a base64 string out or something like that which you could use as cache key?

I was thinking along those lines, but wouldn't that remove even more things from consideration for cache? I suspect object-hash was made specifically because JSON.stringify throws away anything that is not a plain value property, array or a dictionary -- there is nothing else in json spec.

I suppose I could incorporate a hash of package-lock,json and yarn equivalent, if there was a reliable way of finding them. (to mitigate effect of objectHashIgnoreUnknownHack option)

Thanks guys discussing about this issue. Actually clean: true option dose not bypass the cache process so it's not working even a while. However, ignoreUnknown might possibly the way to fix this issue as @ezolenko say. I'll waiting 0.16.2 anyway!

@vwxyutarooo, I was under the assumption that clean: true uses a noop cache strategy. That's what I remember that @ezolenko implemented some time ago. If it still attempts to compute a cache key from the rollup config, that behavior needs looking into in my opinion

I don't know how this affected to object-hash result, However the objectHashIgnoreUnknownHack option on objecthash branch is works for me.

I reworked cache a bit so clean: true will not even invoke object-hash and merged everything into master. I'll release in a few days

In 0.17.0 now

For another workaround not using the objectHashIgnoreUnknownHack hack, I ran into this problem using rollup-plugin-require-context, and the following snippet seems to work:

import requireContextORIGINAL from 'rollup-plugin-require-context'

const requireContext = (options) => {
  const plugin = requireContextORIGINAL(options)
  return {
    name: plugin.name,
    transform(code, id) {
      return plugin.transform(code, id)
    }
  }
}

Namely, making transform a normal function returning a promise.

Thought I'd add an update for folks here that the root cause here was finally fixed in https://github.com/puleos/object-hash/pull/90 (very similar to https://github.com/puleos/object-hash/pull/68 referenced above) and here in #203. No need to use objectHashIgnoreUnknownHack to support async plugins and no more cache issues -- was just released as v0.26.0 🎉 😄