Shinyproxy: app_direct requires unecessary forward slash in url

Created on 18 Apr 2019  ·  3Comments  ·  Source: openanalytics/shinyproxy

The /app_direct/ url will only works if we use:
shinyproxyapp.com/app_direct/myappname/ while shinyproxyapp.com/app/myappname does not require this extra backslah. This is counter intuitive to have set one at the end for the /app_direct/ way.

This has been introduced in ShinyProxy 2.2.0 as earlier we could use /app_direct/ the same way as /app/ without the end slash after app name.

picture dylancis
👍2

Most helpful comment

Hi @dylancis, Thanks for creating the issue. I agree we should fix this.

picture tverbeke on 18 Apr 2019
👍2

All 3 comments

Hi @dylancis, Thanks for creating the issue. I agree we should fix this.

tverbeke picture tverbeke on 18 Apr 2019
👍2

@tverbeke I believe the line in question is here:
https://github.com/openanalytics/shinyproxy/blob/7c5448223fcff55f29ad630f7ac36d380ff68597/src/main/java/eu/openanalytics/shinyproxy/controllers/AppController.java#L112

dylancis picture dylancis on 18 Apr 2019

@dylancis Fixed in ShinyProxy 2.2.2!

tverbeke picture tverbeke on 10 May 2019
❤1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

donarus picture donarus  ·  3Comments
chienyuchuan picture chienyuchuan  ·  8Comments
lucius-verus-fan picture lucius-verus-fan  ·  8Comments
jfrubioz picture jfrubioz  ·  9Comments
ramkumarg1 picture ramkumarg1  ·  7Comments