Advantages:
Disadvantages:
definitely confusing. when it was first brought up I thought it was a joke... but hey. it's shorter so whatever
Math2
?
Math2
goes along the lines of Guava's Collections2
.
Math2
?
Math 2: Electric Boogaloo
As long as it'll have a JavaDoc saying that it's a Math Helper, and it's documented later on, then yes.
Mth doesn't match the naming conventions and imo is not sufficiently descriptive.
I'd rather go with something like McMath to also imply that it's kind of like math, but not very accurate or universal since it sometimes uses low precision approximations.
FastMath
?
()Mth
reads as "meth" to me
I'm not sure if implying Mojang's math is faster is good idea
MathExceptSlightlyWorseButMaybeItsFasterIDunno
meanwhile implying their math is like meth may not be an issue
Maths
. In Great Britain and Australia, mathematics is shortened as "Maths" instead of "Math".
~But the USA doesn't, so we don't either~
Maths seems a little close to Math, which is already a Class in the Java libraries, so people might get confused. Since its purpose seems to be related to in-world math, maybe something like BlockMath could work.
Some methods like square root and partialtick and locatiom is used for rendering.
I prefer MathHelper
over an unpronounceable classname.
Agreed. MathHelper
is fine, and it's used rarely enough by modders that typing it out is not an issue.
Mth is good IMO. Good to use the Mojang names, especially on classes like this that aren't used too much
I think we should get a decision made on this soon
I'll quote @tterrag on this:
so the two sides of the war seem to be expressiveness vs conciseness. So isn't the middle ground Math2?
It's perfectly expressive
Easy to autocomplete
Matches an existing pattern
There is currently no class called Math2 in a default loom workspace. I think it's a very good fit.
Guava has a lot of utility classes that have name clashes with Java Library classes. While older clashes are named like Collections2
, the newer classes are prefixed with More
instead, such as Objects
-> MoreObjects
. As a result, I still suggest MoreMath
or McMath
coined by player.
I like both of them but surely MathHelper is intuitive.
If I have to say I would like to propose MathTool
or MathTools
. Sure Mth
rolls off keyboard faster, but from a non-native speaker's POV... I am not sure if this doesn't create a mess.
Personally I am fine with Mth
.
I'll point out this issue has 12 upvotes and only 4 down. Perhaps a PR should be considered.
Since you commented that, it got 4 more downvotes and only one upvote. So I'd call this controversial at best.
I don't think we should sacrifice a good meaningful name to a bad Mojang Name.
Given the current result 12 :+1: versus 13 :-1:, will keep the current MathHelper
name.
Comment if there is more concerns.
Most helpful comment
I prefer
MathHelper
over an unpronounceable classname.