SystemUtil contains a bunch of static methods. Some of them relate to a "system":
- fine-grained timers
- current operating system
- JVM flags
But many others are completely unrelated:
- patching miscellaneous holes in the Java standard library (
ifPresentOrElse,thenCombine,completeExceptionally,consume,get,toMap, ...) - a bit about the server worker
- reading and writing UUIDs from
Dynamics - an identity hash strategy
- something about translation keys? lol
It appears to be less of a system-related class and more just a dumping ground for random functions that are too small to break into their own named helper class but too broadly applicable to keep near one call site.
Should this class be renamed?
Some suggestions being thrown around on Discord:
MiscUtilUsefulVariaHelperEtcFunny comedy suggesions:
JunkStuffMiscellaneousGameSystemUtilitiesBucketOShi
quat1024
All 6 comments
Util gets my vote. Simple and to the point.
kashike
on 1 Jul 2019
Name it ClassThatWeHaveNoIdeaWhatToNamePleaseHelp
valoeghese
on 1 Jul 2019
I'd go with MinecraftUtil personally but also kashike is god so Util 👍
Prospector
on 1 Jul 2019
Util is good, however it does seem like the majority of the functions are system related. System also doesn't necessarily have to mean _just_ the Operating System. Patching Std lib functions, Uuid serialization, and anything with hashing sounds to me as something that technically qualifies as "system utilities". Not the OS system, but the Java system, they're just so low level. Just Sys would work.
There are also other naming strageties I've used such as Objects/Strings/Collections/etc...
Sollace
on 1 Jul 2019
Generally, kashike has a lot of wisdom here, so I'd go with Util.
asiekierka
on 20 Jul 2019
I personally support Misc.
liach
on 9 Oct 2019
Related issues
Runemoro
·
3Comments
Runemoro
·
4Comments
asiekierka
·
3Comments
enbrain
·
4Comments
Runemoro
·
4Comments
Most helpful comment
Name it
ClassThatWeHaveNoIdeaWhatToNamePleaseHelp