Etherpad-lite: Wrong url address when I use read only mode

Works fine here: https://video.etherpad.com/p/testreadonlyURI

Possibly a setting?

Video.etherpad.com is running nginx reverse proxy too..

@JohnMcLear I see, but i use settings without /p/ - https://github.com/ether/etherpad-lite/wiki/How-to-put-Etherpad-Lite-behind-a-reverse-Proxy#hosted-at--with-friendly-urls-for-pads

Afaik the read only URI is computed based on the location of /p/, I think you would need to look at the logic around that and compute it from a setting or so? Are you hoping to hack on some of this stuff or just making issues for now?

I just don't want them to go into a black hole because I wouldn't consider this a bug but a quirk of your specific deployment so for core devs it's gonna be low down on the priority list -_- We don't like having open bugs though!

Afaik the read only URI is computed based on the location of /p/

Why do we need to get attached to some parameter? protocol + "://" + domain + "/p/" + read only parameter

Are you hoping to hack on some of this stuff or just making issues for now?

I followed the instructions from your wiki. I like this setting, where there are no extra parameters in the url.

I showed that with this configuration and the inclusion of "read-only", the URL breaks and there is no mention of a domain.

We don't like having open bugs though!

And who loves bugs?

@alekso87, I am sure there is some quirk somewhere in the code.

If possible, try to find it, and send a PR.

If it takes too much time, or happens to be too difficult, please update the wiki page mentioning the problem you just found. At least this would not be surprising anymore.

That would be helpful and really appreciated. Thank you.

@muxator what PR can be used for this fix? I have a solution to fix that.

I think what @muxator is saying is that you will need to create a pr to address this bug or sit tight and wait for us to get to it. Be forewarned though I'm dealing with bugs from 2012 I never got around to fixing :p

Nice job on getting a PR in! We will review ASAP. We're currently in release mode so give us a few days to get this release out please <3

@JohnMcLear I have not yet worked in fork mode, so in the first PR I added too many commits :( Now I want to work out a scheme for myself in which I will not push extra commits into the PR.

@alekso87 I feel your pain. Git can be a fickle mistress.