Feathers: Public / Private services

To disable the "external" access to my service, I have to use hooks like hooks.disallow('external')

Yes, you should use something like:

app.use('/mypath', myservice)
app.service('/mypath').hooks({
  before: { all: [hooks.disallow('external')] } 
})

Should I define this "private services" a completely different way ?

My suggestion would be to have like a private namespace and then use a global hook. Whenever you want a private service just name them like so /private/svc1 /private/svc2, then make a global app hook that conditionally applies disallow('external').

You can keep you folder structures however you please, it's only the service name that matters. But I do both. Like all my DB services are in a DB folder and I also name space them like so db/users ...

Like, just adding them to the app like this app.set('mailer', mailer) and lose the benefit of service hooks.

Not a good idea. Keep sticking to app.use()

Can we use the application as a services containers and what is the recommended way to inject services into other services ? Get them from the app ? Like app.service('xxx') ?

The recommended way, and what I also stick to, is to use ES6 Classes for services, in which case you get a setup method that provides the app object.

export default class Service {
 setup(app) {
    this.app = app;
    this.svc2 = app.service('svc2');
  }

  create(data) {
    // use this.svc2 here now 
  }
}

app.use('/service', new Service());

Also, when using the cli and generating a service. Every service get a name option. What is this name use for ? When we call app.service(xxx), it resolves by the service attach to the path xxx, right ?

I don't use cli in my project as it was more of a migration from express than a fresh one. So I'm not fully sure about that aspect. But yes when we call app.service('xyz'), it resolves them by the path you defined when adding the service app.use('xyz', new Xyz())

Thank you @subodhpareek18, that's exactly it 😄

You can find those now at feathers-plus/feathers-hooks-common#disallow.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.