Ink-text-input: handleSubmit
The quickstart on readme.md mentioned this.handleSubmit = this.handleSubmit.bind(this);, which is empty and will set off error.
Moreover, onChange is handled properly while onSubmit is not.
Maybe we need to handle ENTER?
if(s === ENTER && this.props.onSubmit && value !== originalValue){
return this.props.onSubmit(value);
}
entrptaher
All 11 comments
I was just about to open an issue for this. Would be awesome! (And I see the deprecated password input component has onSubmit)
SimenB
on 8 Mar 2019
3rded - for now I've copied the code into a file locally and added my own onSubmit method
danrspencer
on 8 Mar 2019
4thed - I added my own custom onSubmit too.
jcar787
on 8 Mar 2019
@danrspencer @jcar787 let's do a pull request, what do you say? :D
entrptaher
on 9 Mar 2019
@entrptaher I think you should do it since you discovered the issue first and added the gist. 😊
Thanks for the gist though.
jcar787
on 9 Mar 2019
You are right.
However, I dug deep into it and found I had problem with cursorOffset when I submit using ENTER.
Then I asked on this issue :D
entrptaher
on 9 Mar 2019
Hook version. You don't get the value from it though.
mAAdhaTTah
on 11 Mar 2019
I guess I accidentally removed it when migrating to Ink 2 or earlier 🤷♂️ If anyone's willing to help out with this, would be great! If not, I will take care of it bit later this week.
vadimdemedes
on 13 Mar 2019
19 is merged, this can be closed 🎉
SimenB
on 16 Mar 2019
@SimenB let me test the cursorOffset, I am really curious about it. :D
entrptaher
on 16 Mar 2019
This works flawlessly.
The issue can be closed.
Result:
Many thanks everyone.
Gonna go find next bug :D
entrptaher
on 16 Mar 2019
Related issues
colinking
·
3Comments
mwawrusch
·
3Comments
danieljack
·
3Comments
exortech
·
3Comments
iklementiev
·
3Comments
Most helpful comment
3rded - for now I've copied the code into a file locally and added my own
onSubmitmethod