Openapoc: CTD: transfering engineers

Selling/buying from one to the other works but they stay assigned and their proficiency keeps counting.

https://i.imgur.com/N6e2h6t.png

Did you start new game? The fix to scientist bug only works for the new saves.

Yes, brand new game with the OpenApoc-x64-v0.1-345-gea6033fa build, which I took as the "stable" 345 master build.

Ok I will take a look.

Another example of this bug

Savegame Attached
(May need old weapons mod from the discord modding channel)
save_Medium Test 06-02-19 1.zip

Please see also issue #532 which is a duplicate

saves.zip
Here my last 3 saves to debug

https://github.com/OpenApoc/OpenApoc/issues/532#issue-421676938

gdb log and stack trace for 1 of #532 issue

532_1_gdb_log_n_stack_trace.txt

Also there is no crash on case 2. It's just shows MessageDialog with "Alien Containment exeeded"

Ah, the alien containment issue is good old #369 i'll reference this there too
Thanks for the report <3

See also #370

stack trace for case 3

532_3_gdb_log_n_stack_trace.txt

Here a screen shot

Left is Biochemie with 9 scientist. Every time i klick on the Lab, i get the message you can see.

After a lot of smth like that message dialogs game crashes.

I think what's happening here is when transferring or selling scientists it's not disassociating them from any lab they're currently working in, so the lab holds a reference to that agent.

And nearly always you get a missing ID error, it'll crash directly afterwards - as it'll return a null object - so unless the code then doesn't use the object at all (in which case why is it bothering to look it up?) it'll deference that null pointer.

@JonnyH another instance of this bug
Here's the crash dump
Created when trying to transfer a skill 100 engineer from Base 1 to Base 2

save_Expanded Weapons Test 1.zip

OpenApoc.exe.10340.dmp.zip

To run the savegame, you will need V3 of the weapons mod
XCOM UFO TFTD Weapons Mod - Voiddweller and FilmBoy84 v3.zip

Cannot reproduce -- should be fixed by #720.