Plots2: Remove "tags" icon from tag input

Created on 19 Oct 2020  ·  7Comments  ·  Source: publiclab/plots2

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • [ ] 📝 Update the file app/views/tag/_form.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Here, we'll be removing an icon as shown in this screenshot:

image

The icon appears in a form on the sidebar of pages like https://publiclab.org/notes/warren/09-14-2020/congratulations-to-our-outreachy-and-gsoc-2020-fellows (login required to see it)

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -4,9 +4,6 @@
   <div class="control-group">
     <input class="form-control" name="remote" type="hidden" value="true" />
     <div class="input-group">
-      <div class="input-group-prepend">
-        <span class="input-group-text"><i class="fa fa-tags"></i></span>
-      </div>
       <input aria-label="Enter tag name" autocomplete="off" class="tag-input form-control" name="name" type="text" placeholder="<%= translation('tag._tagging.enter_tags') %>" data-provide="typeahead" />
       <div class="input-group-append">
         <a class="btn btn-outline-secondary blurred-location-input" rel="tooltip" title="Link with a location" style="border-color:#ccc;">
  • [ ] 💾 Commit your changes

  • [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  • If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.
  • If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.
  1. You can also edit files directly in your browser and open a pull request from there.
  • [ ] 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

This will address part of #6593

first-timers-only help wanted

Most helpful comment

Hello @kimcheung i don't know but i have searched your name on the publiclab's chatroom on guitter but i didnt find. are you part of it? if not, here is the link: https://gitter.im/publiclab/publiclab please join.

All 7 comments

i will work on this issue

Hi @tawahpeggy - as you've completed a first-timers-only issue at https://github.com/publiclab/plots2/issues/8572, would you like to help someone else take this up as their very first one? Maybe one of the people who has asked for an issue in the chatroom in the past couple days?

Thank you so much!!

Hi! 👋 Can I take this on?

Go ahead @kimcheung , thanks

Hello @kimcheung i don't know but i have searched your name on the publiclab's chatroom on guitter but i didnt find. are you part of it? if not, here is the link: https://gitter.im/publiclab/publiclab please join.

great work on your first PR @kimchueng. keep up, the sky is your starting
point.
now that you have completed your FTO start a hunt to search for other non
FTO issues here:
https://github.com/publiclab/plots2/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22.
a common mistake is to forget that the issues page is paginated and we
may tend to check just the first, when there are up to 8 pages.

On Tue, Oct 20, 2020 at 4:19 PM Kim Cheung notifications@github.com wrote:

PR: #8638 https://github.com/publiclab/plots2/pull/8638


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/8623#issuecomment-712929512,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJT4KDUGUFPXQGTYBD2YVY3SLWS7HANCNFSM4SWYTGIQ
.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

first-timers[bot] picture first-timers[bot]  ·  3Comments

keshavsethi picture keshavsethi  ·  3Comments

RuthNjeri picture RuthNjeri  ·  3Comments

milaaraujo picture milaaraujo  ·  3Comments

keshavsethi picture keshavsethi  ·  3Comments